Skip to content

Second CardType does not contain tamper: true #39

@Patabugen

Description

@Patabugen

I've been debugging SagePay callback errors which were giving me the error Undefined index: CardType in Academe/SagePay/Server.php on line 247

I believe this is caused by the duplicated CardType in Metadata/Transaction.php (noted in comment on line 23) because the second CardType does not contain the "tamper": true, field (the first one does).

Since the key is duplicated, the first one is ignored - I'd suggest we merge the two card type lists and consider how we might separate them again in future if we need to have different data types per source (the validation will be slightly less strict, but at the moment I'm not sure how or why it would even be working for server-notification - the first one.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions