Add Jason encoding impl for non binary backends

Author: acalejos

.github/workflows/precompile.yml

@@ -13,9 +13,9 @@ jobs:
     strategy:
       matrix:
         # Elixir 1.14.5 is first version compatible with OTP 26
-        # NIF versionsss change according to
+        # NIF versions change according to
         # https://github.com/erlang/otp/blob/dd57c853a324a9572a9e5ce227d8675ff004c6fe/erts/emulator/beam/erl_nif.h#L33
-        otp: ["25.0", "26.0"]
+        otp: ["25.0", "26.0", "27.0"]
         elixir: ["1.14.5"]
     steps:
       - uses: actions/checkout@v3
@@ -32,7 +32,7 @@ jobs:
       - name: Mix Test
         run: |
           mix deps.get
-          MIX_ENV=test mix test
+          MIX_ENV=test mix tests
       - name: Create precompiled library
         run: |
           export ELIXIR_MAKE_CACHE_DIR=$(pwd)/cache
@@ -49,13 +49,13 @@ jobs:
     # Homebrew supports versioned Erlang/OTP but not Elixir
     # It's a deliberate design decision from Homebrew to
     # only support versioned distrinutions for certin packages
-    name: Mac (${{ matrix.runner == 'macos-latest' && 'Intel' || 'ARM' }}) Erlang/OTP ${{matrix.otp}} / Elixir
+    name: Mac (${{ matrix.runner == 'macos-13' && 'Intel' || 'ARM' }}) Erlang/OTP ${{matrix.otp}} / Elixir
     env:
       MIX_ENV: "prod"
     strategy:
       matrix:
-        runner: ["macos-latest", "exgboost-m2-runner"]
-        otp: ["25.0", "26.0"]
+        runner: ["macos-13", "macos-14"]
+        otp: ["25.0", "26.0", "27.0"]
         elixir: ["1.14.5"]
     steps:
       - uses: actions/checkout@v3
@@ -82,7 +82,4 @@ jobs:
         if: startsWith(github.ref, 'refs/tags/')
         with:
           files: |
-            ${{ matrix.runner == 'macos-latest' && 'cache/*x86_64*.tar.gz' || 'cache/*aarch64*.tar.gz' }}
-      - name: Cleanup # We need this since self-hosted runners are not ephemeral
-        run: |
-          make clean
+            ${{ matrix.runner == 'macos-13' && 'cache/*x86_64*.tar.gz' || 'cache/*aarch64*.tar.gz' }}

lib/exgboost/internal.ex

@@ -111,20 +111,31 @@ defmodule EXGBoost.Internal do
   # a string, so if we pass string NaN to XGBoost, it will fail.
   # This allows the user to use Nx.Constants.nan() and have it work as expected.
   defimpl Jason.Encoder, for: Nx.Tensor do
-    def encode(%Nx.Tensor{data: %Nx.BinaryBackend{state: <<0x7FC0::16-native>>}}, _opts),
-      do: "NaN"
+    @binary_nans [
+      <<0x7FC0::16-native>>,
+      <<0x7E00::16-native>>,
+      <<0x7FC00000::32-native>>,
+      <<0x7FF8000000000000::64-native>>
+    ]
+    def encode(%Nx.Tensor{data: %Nx.BinaryBackend{state: state}}, _opts)
+        when state in @binary_nans,
+        do: "NaN"
 
-    def encode(%Nx.Tensor{data: %Nx.BinaryBackend{state: <<0x7E00::16-native>>}}, _opts),
-      do: "NaN"
+    def encode(%Nx.Tensor{} = tensor, _opts) do
+      case Nx.to_binary(tensor, limit: 1) do
+        binary when binary in @binary_nans ->
+          "NaN"
 
-    def encode(%Nx.Tensor{data: %Nx.BinaryBackend{state: <<0x7FC00000::32-native>>}}, _opts),
-      do: "NaN"
+        _ ->
+          raise ArgumentError,
+                """
+                JSON Encoding only implemented for NaN Tensors (Nx.Constants.nan())!
 
-    def encode(
-          %Nx.Tensor{data: %Nx.BinaryBackend{state: <<0x7FF8000000000000::64-native>>}},
-          _opts
-        ),
-        do: "NaN"
+                This normally is only used to map the `missing` parameter during EXGBoost
+                training when `missing` is Nx.Constants.nan()
+                """
+      end
+    end
   end
 
   def unwrap!({:ok, val}), do: val

mix.exs

@@ -1,6 +1,6 @@
 defmodule EXGBoost.MixProject do
   use Mix.Project
-  @version "0.5.0"
+  @version "0.5.1"
 
   def project do
     [
@@ -47,7 +47,7 @@ defmodule EXGBoost.MixProject do
     [
       {:elixir_make, "~> 0.4", runtime: false},
       {:nimble_options, "~> 1.0"},
-      {:nx, "~> 0.5"},
+      {:nx, "~> 0.7"},
       {:jason, "~> 1.3"},
       {:ex_doc, "~> 0.31.0", only: :docs},
       {:cc_precompiler, "~> 0.1.0", runtime: false},

mix.lock

@@ -24,7 +24,7 @@
   "nimble_csv": {:hex, :nimble_csv, "1.2.0", "4e26385d260c61eba9d4412c71cea34421f296d5353f914afe3f2e71cce97722", [:mix], [], "hexpm", "d0628117fcc2148178b034044c55359b26966c6eaa8e2ce15777be3bbc91b12a"},
   "nimble_options": {:hex, :nimble_options, "1.1.0", "3b31a57ede9cb1502071fade751ab0c7b8dbe75a9a4c2b5bbb0943a690b63172", [:mix], [], "hexpm", "8bbbb3941af3ca9acc7835f5655ea062111c9c27bcac53e004460dfd19008a99"},
   "nimble_parsec": {:hex, :nimble_parsec, "1.4.0", "51f9b613ea62cfa97b25ccc2c1b4216e81df970acd8e16e8d1bdc58fef21370d", [:mix], [], "hexpm", "9c565862810fb383e9838c1dd2d7d2c437b3d13b267414ba6af33e50d2d1cf28"},
-  "nx": {:hex, :nx, "0.6.4", "948d9f42f81e63fc901d243ac0a985c8bb87358be62e27826cfd67f58bc640af", [:mix], [{:complex, "~> 0.5", [hex: :complex, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.0 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "bb9c2e2e3545b5eb4739d69046a988daaa212d127dba7d97801c291616aff6d6"},
+  "nx": {:hex, :nx, "0.7.2", "7f6f6584585e49ffbf81769e7ccc2d01c5639074e399c1f94adc2b509869673e", [:mix], [{:complex, "~> 0.5", [hex: :complex, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.0 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "e2c0680066eec5af8b8ef00c99e9bf40a0d08d8b2bbba77f59f801ec54a3f90e"},
   "parse_trans": {:hex, :parse_trans, "3.4.1", "6e6aa8167cb44cc8f39441d05193be6e6f4e7c2946cb2759f015f8c56b76e5ff", [:rebar3], [], "hexpm", "620a406ce75dada827b82e453c19cf06776be266f5a67cff34e1ef2cbb60e49a"},
   "scidata": {:hex, :scidata, "0.1.11", "fe3358bac7d740374b4f2a7eff6a1cb02e5ee7f87f7cdb1e8648ad93c533165f", [:mix], [{:castore, "~> 0.1", [hex: :castore, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}, {:nimble_csv, "~> 1.1", [hex: :nimble_csv, repo: "hexpm", optional: false]}, {:stb_image, "~> 0.4", [hex: :stb_image, repo: "hexpm", optional: true]}], "hexpm", "90873337a9d5fe880d640517efa93d3c07e46c8ba436de44117f581800549f93"},
   "ssl_verify_fun": {:hex, :ssl_verify_fun, "1.1.7", "354c321cf377240c7b8716899e182ce4890c5938111a1296add3ec74cf1715df", [:make, :mix, :rebar3], [], "hexpm", "fe4c190e8f37401d30167c8c405eda19469f34577987c76dde613e838bbc67f8"},