[data_dict (legacy)] fix description not updating upon refresh (#9681)

fixes #9618

Author: shonibare

modules/datadict/ajax/UpdateDataDict.php

@@ -29,6 +29,7 @@
 $client = new NDB_Client();
 $client->initialize();
 
+$DB = \NDB_Factory::singleton()->database();
 
 list($name,$extra) = explode("___", $_REQUEST['fieldname']);
 

modules/datadict/php/datadict.class.inc

@@ -59,7 +59,7 @@ class Datadict extends \DataFrameworkMenu
      */
     public function getFieldOptions() : array
     {
-        $instruments     = \Utility::getAllInstruments();
+        $instruments     = \NDB_BVL_Instrument::getInstrumentNamesList($this->loris);
         $dictInstruments = [];
         $user            = \User::singleton();
 

modules/datadict/php/fields.class.inc

@@ -35,7 +35,8 @@ class Fields extends \NDB_Page
         }
         return new \LORIS\Http\Response\JSON\OK(
             [
-                'sourceFrom' => \Utility::getAllInstruments(),
+                'sourceFrom' =>
+                \NDB_BVL_Instrument::getInstrumentNamesList($this->loris),
                 'cohort'     => $cohort_options
             ]
         );