-
Notifications
You must be signed in to change notification settings - Fork 188
adjustments to elements in the candidate profile item page #10082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marandmart
wants to merge
6
commits into
aces:main
Choose a base branch
from
marandmart:candidate_profile_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
previously approved these changes
Oct 31, 2025
Collaborator
|
@driusan I think one of the last taks was a weirdness about the height of the panels, in some cases they stretched to infinity taking over their entire column and in mobile view I suggested the panels to go into one column because it didnt make any sense on a tight enough screen. |
Contributor
|
@marandmart before clicking on a candidate, there is the filter table having weird dimensions: |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Language: Javascript
PR or issue that update Javascript code
Language: PHP
PR or issue that update PHP code
Module: candidate_profile
PR or issue related to candidate_profile module
Module: instruments
PR or issue related to instruments module
Module: media
PR or issue related to media module
State: Needs work
PR awaiting additional work by the author to proceed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Brief summary of changes
Solves issue: https://github.com/aces/CBIGR/issues/559
Example page: candidate_profile/587630/
Before:

After:

Before:

After:

Before:

After:

Before:

After:

Before:

After:

Before:


After:

