Prevent object reference sharing in array operations

Shallow copy objects in `pull`, `push`, `insert`, and `update` functions to avoid unintended reference sharing. Added corresponding test cases to ensure objects are not shared between input and output arrays.

Author: imagine10255

src/array/array.spec.ts

@@ -35,6 +35,12 @@ describe('array', () => {
         it('should return not modify source', () => {
             expect(sourceArray).toEqual([1, 2]);
         });
+
+        it('should not share object reference', () => {
+            const obj = {id: 1};
+            const result = pull([{id: 2}], obj);
+            expect(result[0]).not.toBe(obj);
+        });
     });
 
     describe('push', () => {
@@ -47,6 +53,11 @@ describe('array', () => {
         it('should return not modify source', () => {
             expect(sourceArray).toEqual([1, 2]);
         });
+        it('should not share object reference', () => {
+            const obj = {id: 1};
+            const result = push([{id: 2}], obj);
+            expect(result[2]).not.toBe(obj);
+        });
     });
 
     describe('move', () => {
@@ -76,8 +87,11 @@ describe('array', () => {
             const result = insert(null, 1, 'A');
             expect(result).toStrictEqual(['A']);
         });
-
-
+        it('should not share object reference', () => {
+            const obj = {id: 9};
+            const result = insert([{id: 1}, {id: 2}], 1, obj);
+            expect(result[1]).not.toBe(obj);
+        });
     });
 
 

src/array/array.ts

@@ -10,8 +10,10 @@ import {SortOrder, TArrayOrEmpty, TEmpty,TGroupByFn, TGroupTreeBy, TSortByFn} fr
  * @param pullData
  */
 export function pull<T, A extends TArrayOrEmpty<T>>(arrayData: A, pullData: T): A {
-    if(!arrayData) return [pullData] as A;
-    return [pullData].concat(arrayData.slice(0)) as A;
+    // 防止物件共享引用：對物件進行淺拷貝
+    const item = (pullData && typeof pullData === 'object') ? {...pullData} : pullData;
+    if(!arrayData) return [item] as A;
+    return [item].concat(arrayData.slice(0)) as A;
 }
 
 /**
@@ -24,8 +26,10 @@ export function pull<T, A extends TArrayOrEmpty<T>>(arrayData: A, pullData: T):
  * @param pushData
  */
 export function push<T, A extends TArrayOrEmpty<T>>(arrayData: A, pushData: T): T[] {
-    if(!arrayData) return [pushData] as T[];
-    return arrayData.slice(0).concat(pushData) as T[];
+    // 防止物件共享引用：對物件進行淺拷貝
+    const item = (pushData && typeof pushData === 'object') ? {...pushData} : pushData;
+    if(!arrayData) return [item] as T[];
+    return arrayData.slice(0).concat(item) as T[];
 }
 
 /**
@@ -39,8 +43,10 @@ export function push<T, A extends TArrayOrEmpty<T>>(arrayData: A, pushData: T):
  * @param data
  */
 export function insert<T, A extends TArrayOrEmpty<T>>(arrayData: A, index: number, data: T): T[] {
-    if(!arrayData) return [data] as T[];
-    return [...arrayData.slice(0, index), data, ...arrayData.slice(index)] as T[];
+    // 防止物件共享引用：對物件進行淺拷貝
+    const item = (data && typeof data === 'object') ? {...data} : data;
+    if(!arrayData) return [item] as T[];
+    return [...arrayData.slice(0, index), item, ...arrayData.slice(index)] as T[];
 }
 
 /**
@@ -150,13 +156,13 @@ export function updateByIndex<T, A extends TArrayOrEmpty<T>>(arrayData: T[]|A, i
     if(index === -1 || !arrayData || index > arrayData.length - 1) return arrayData as A;
 
     // Copy new object
-    const newDaa: T = {...arrayData[index]};
+    const newData: T = {...arrayData[index]};
 
-    updateFn(newDaa);
+    updateFn(newData);
 
     // Copy new array
     const newArrayData: T[] = [...arrayData];
-    newArrayData[index] = newDaa;
+    newArrayData[index] = newData;
     return newArrayData as A;
 }