Define and apply new eslint rules (jerryscript-project#1270)

apply only rules that are automatically modified.

IoT.js-DCO-1.0-Signed-off-by: Hosung Kim hs852.kim@samsung.com

Author: hs0225

.eslintignore

@@ -1,2 +1,3 @@
 /build/**
 /deps/**
+/src/js/ble*

.eslintrc.js

@@ -1,12 +1,91 @@
+/* Copyright 2017-present Samsung Electronics Co., Ltd. and other contributors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+var es6 = {
+  'generator-star-spacing': [2, 'after'],
+  'no-var': 2,
+  'prefer-rest-params': 2,
+  'prefer-spread': 2,
+  'rest-spread-spacing': 2,
+  'yield-star-spacing': [2, 'after'],
+}
+
+var eslintRecommended = {
+  'no-console': 0,
+  'no-empty': 0, // TODO: remove this feature
+}
+
+var style = {
+  'no-multi-spaces': 2,
+  'no-multi-str': 2,
+  'array-bracket-spacing': [2, 'never'],
+  'block-spacing': [2, 'never'],
+  'brace-style': 2,
+  'comma-dangle': [2, 'always-multiline'],
+  'comma-spacing': 2,
+  'comma-style': 2,
+  'computed-property-spacing': 2,
+  'eol-last': 2,
+  'func-call-spacing': 2,
+  'key-spacing': 2,
+  'keyword-spacing': 2,
+  'linebreak-style': 2,
+  'no-multiple-empty-lines': [2, {max: 2}],
+  'no-tabs': 2,
+  'no-trailing-spaces': 2,
+  'semi-spacing': 2,
+  'space-before-blocks': 2,
+  'space-before-function-paren': [2, {
+    anonymous: 'never',
+    named: 'never',
+  }],
+  'spaced-comment': [2, 'always'],
+  'switch-colon-spacing': 2,
+  'quotes': [2, 'single'],
+}
+
+var syntax = {
+  'no-plusplus': 0,
+  'guard-for-in': 2,
+  'no-caller': 2,
+  'no-extend-native': 2,
+  'no-new-wrappers': 2,
+  'new-cap': 2,
+  'no-array-constructor': 2,
+  'no-new-object': 2,
+  'semi': 2,
+}
+
 module.exports = {
   'extends': 'eslint:recommended',
-  'rules': {
-    'no-console': 0,
-    'no-constant-condition': 0,
-    'no-empty': 0,
-    'no-undef': 0,
-    'no-unused-vars': 0,
-    'no-plusplus': 0,
-    'no-redeclare': 0,
-  }
+  'env': {
+    'node': true,
+    'es6': false,
+  },
+  'rules': Object.assign(
+    eslintRecommended,
+    style,
+    syntax,
+    {
+      // Optional rules
+      'max-len': [2, {
+        code: 80,
+        tabWidth: 2,
+        ignoreUrls: true,
+        ignoreTemplateLiterals: true,
+        ignoreRegExpLiterals: true
+      }],
+  }),
 }

src/js/assert.js

@@ -69,7 +69,7 @@ function fail(actual, expected, message, operator) {
     message: message,
     actual: actual,
     expected: expected,
-    operator: operator
+    operator: operator,
   });
 }
 

src/js/buffer.js

@@ -214,7 +214,7 @@ Buffer.prototype.slice = function(start, end) {
 // * start - default to 0
 // * end - default to buff.length
 Buffer.prototype.toString = function(start, end) {
-  if (util.isString(start) && start === "hex" && end === undefined) {
+  if (util.isString(start) && start === 'hex' && end === undefined) {
       return this._builtin.toHexString();
   }
   start = start === undefined ? 0 : ~~start;

src/js/dgram.js

@@ -152,7 +152,7 @@ Socket.prototype.bind = function(port, address, callback) {
   });
 
   return self;
-}
+};
 
 
 // thin wrapper around `send`, here for compatibility with dgram_legacy.js
@@ -242,11 +242,11 @@ Socket.prototype.send = function(buffer, offset, length, port, address,
 
   if (!util.isArray(buffer)) {
     if (util.isString(buffer)) {
-      list = [ new Buffer(buffer) ];
+      list = [new Buffer(buffer)];
     } else if (!util.isBuffer(buffer)) {
       throw new TypeError('First argument must be a buffer or a string');
     } else {
-      list = [ buffer ];
+      list = [buffer];
     }
   } else if (!(list = fixBufferList(buffer))) {
     throw new TypeError('Buffer list arguments must be buffers or strings');
@@ -298,7 +298,7 @@ function doSend(ex, self, ip, list, address, port, callback) {
 
   var buf = Buffer.concat(list);
 
-  var err = self._handle.send(buf, port, ip, function (err, length) {
+  var err = self._handle.send(buf, port, ip, function(err, length) {
     if (err) {
       err = util.exceptionWithHostPort(err, 'send', address, port);
     } else {

src/js/events.js

@@ -35,7 +35,7 @@ EventEmitter.prototype.emit = function(type) {
     if (err instanceof Error) {
       throw err;
     } else {
-      throw Error("Uncaught 'error' event");
+      throw Error('Uncaught \'error\' event');
     }
   }
 

src/js/fs.js

@@ -21,7 +21,7 @@ var fsBuiltin = process.binding(process.binding.fs);
 
 fs.exists = function(path, callback) {
   if (!path || !path.length) {
-    process.nextTick(function () {
+    process.nextTick(function() {
       if (callback) callback(false);
     });
     return;
@@ -213,7 +213,7 @@ fs.readFile = function(path, callback) {
     fs.close(fd, function(err) {
       return callback(err, Buffer.concat(buffers));
     });
-  }
+  };
 };
 
 

src/js/gpio.js

@@ -21,7 +21,7 @@ var util = require('util');
 var defaultConfiguration = {
   direction: gpio.DIRECTION.OUT,
   mode: gpio.MODE.NONE,
-  edge: gpio.EDGE.NONE
+  edge: gpio.EDGE.NONE,
 };
 
 
@@ -53,7 +53,7 @@ function gpioPinOpen(configuration, callback) {
         throw new TypeError('Bad configuration - pin is mandatory and number');
       }
     } else {
-      throw new TypeError('Bad arguments - configuration should be Object')
+      throw new TypeError('Bad arguments - configuration should be Object');
     }
 
     // validate direction

src/js/http.js

@@ -26,7 +26,7 @@ exports.request = function(options, cb) {
 };
 
 
-exports.createServer = function(requestListener){
+exports.createServer = function(requestListener) {
   return new Server(requestListener);
 };
 

src/js/http_client.js

@@ -106,8 +106,7 @@ function socketOnClose() {
       res.emit('close');
     });
     res.push(null);
-  }
-  else if (!req.res) {
+  } else if (!req.res) {
     // socket closed before response starts.
     var err = new Error('socket hang up');
     req.emit('error', err);
@@ -173,7 +172,6 @@ function socketOnEnd() {
 }
 
 
-
 // This is called by parserOnHeadersComplete after response header is parsed.
 // TODO: keepalive support
 function parserOnIncomingClient(res, shouldKeepAlive) {
@@ -194,7 +192,7 @@ function parserOnIncomingClient(res, shouldKeepAlive) {
   req.emit('response', res);
 
   // response to HEAD req has no body
-  var isHeadResponse =  (req.method == 'HEAD');
+  var isHeadResponse = (req.method == 'HEAD');
 
   return isHeadResponse;