refactor(solana): Improve RPC error detection

RPC errors must also be evaluated at the caching/aggregator layer to
avoid rotating to another provider in the event that the first provider
fails. Some failures cannot be resolved and need to be aborted
immediately.

Author: pxrl

package.json

@@ -1,7 +1,7 @@
 {
   "name": "@across-protocol/sdk",
   "author": "UMA Team",
-  "version": "4.3.69",
+  "version": "4.3.70",
   "license": "AGPL-3.0",
   "homepage": "https://docs.across.to/reference/sdk",
   "files": [

src/providers/solana/quorumFallbackRpcFactory.ts

@@ -1,9 +1,10 @@
+import { Logger } from "winston";
 import { RpcFromTransport, RpcResponse, RpcTransport, SolanaRpcApiFromTransport } from "@solana/kit";
-import { CachedSolanaRpcFactory } from "./cachedRpcFactory";
-import { SolanaBaseRpcFactory, SolanaClusterRpcFactory } from "./baseRpcFactories";
 import { isPromiseFulfilled, isPromiseRejected } from "../../utils/TypeGuards";
 import { compareSvmRpcResults, createSendErrorWithMessage } from "../utils";
-import { Logger } from "winston";
+import { CachedSolanaRpcFactory } from "./cachedRpcFactory";
+import { SolanaBaseRpcFactory, SolanaClusterRpcFactory } from "./baseRpcFactories";
+import { shouldFailImmediate } from "./utils";
 
 // This factory stores multiple Cached RPC factories so that users of this factory can specify multiple RPC providers
 // and the factory will fallback through them if any RPC calls fail. This factory also implements quorum logic amongst
@@ -64,6 +65,11 @@ export class QuorumFallbackSolanaRpcFactory extends SolanaBaseRpcFactory {
               throw error;
             }
 
+            // If one RPC provider reverted, others likely will too. Skip them.
+            if (quorumThreshold === 1 && shouldFailImmediate(method, error)) {
+              throw error;
+            }
+
             const currentFactory = factory.rpcFactory.clusterUrl;
             const nextFactory = fallbackFactories.shift()!;
             this.logger.debug({

src/providers/solana/retryRpcFactory.ts

@@ -1,10 +1,11 @@
+import { Logger } from "winston";
 import { RpcTransport, SOLANA_ERROR__RPC__TRANSPORT_HTTP_ERROR } from "@solana/kit";
 import { getThrowSolanaErrorResponseTransformer } from "@solana/rpc-transformers";
+import { isSolanaError } from "../../arch/svm";
+import { delay } from "../../utils";
 import { SolanaClusterRpcFactory } from "./baseRpcFactories";
 import { RateLimitedSolanaRpcFactory } from "./rateLimitedRpcFactory";
-import { isSolanaError, SVM_SLOT_SKIPPED, SVM_LONG_TERM_STORAGE_SLOT_SKIPPED } from "../../arch/svm";
-import { delay } from "../../utils";
-import { Logger } from "winston";
+import { shouldFailImmediate } from "./utils";
 
 // This factory adds retry logic on top of the RateLimitedSolanaRpcFactory.
 // It follows the same composition pattern as other factories in this module.
@@ -67,7 +68,7 @@ export class RetrySolanaRpcFactory extends SolanaClusterRpcFactory {
         getThrowSolanaErrorResponseTransformer()(response, { methodName: method, params });
         return response;
       } catch (error) {
-        if (retryAttempt++ >= this.retries || this.shouldFailImmediate(method, error)) {
+        if (retryAttempt++ >= this.retries || shouldFailImmediate(method, error)) {
           throw error;
         }
 
@@ -82,29 +83,6 @@ export class RetrySolanaRpcFactory extends SolanaClusterRpcFactory {
     }
   }
 
-  /**
-   * Determine whether a Solana RPC error indicates an unrecoverable error that should not be retried.
-   * @param method RPC method name
-   * @param error Error object from the RPC call
-   * @returns True if the request should be aborted immediately, otherwise false
-   */
-  private shouldFailImmediate(method: string, error: unknown): boolean {
-    if (!isSolanaError(error)) {
-      return false;
-    }
-
-    // JSON-RPC errors: https://www.quicknode.com/docs/solana/error-references
-    const { __code: code } = error.context;
-    switch (method) {
-      case "getBlock":
-      case "getBlockTime":
-        // No block at the requested slot. This may not be correct for blocks > 1 year old.
-        return [SVM_SLOT_SKIPPED, SVM_LONG_TERM_STORAGE_SLOT_SKIPPED].includes(code);
-      default:
-        return false;
-    }
-  }
-
   /**
    * Identify whether an error thrown was the result of an RPC provider 429 response.
    * @param error Error object from the RPC query.

src/providers/solana/utils.ts

@@ -1,4 +1,5 @@
 import { RpcTransport } from "@solana/rpc-spec";
+import { isSolanaError, SVM_SLOT_SKIPPED, SVM_LONG_TERM_STORAGE_SLOT_SKIPPED } from "../../arch/svm";
 
 /**
  * This is the type we pass to define a Solana RPC request "task".
@@ -12,3 +13,26 @@ export interface SolanaRateLimitTask {
   resolve: (result: unknown) => void;
   reject: (err: unknown) => void;
 }
+
+/**
+ * Determine whether a Solana RPC error indicates an unrecoverable error that should not be retried.
+ * @param method RPC method name.
+ * @param error Error object from the RPC call.
+ * @returns True if the request should be aborted immediately, otherwise false.
+ */
+export function shouldFailImmediate(method: string, error: unknown): boolean {
+  if (!isSolanaError(error)) {
+    return false;
+  }
+
+  // JSON-RPC errors: https://www.quicknode.com/docs/solana/error-references
+  const { __code: code } = error.context;
+  switch (method) {
+    case "getBlock":
+    case "getBlockTime":
+      // No block at the requested slot. This may not be correct for blocks > 1 year old.
+      return [SVM_SLOT_SKIPPED, SVM_LONG_TERM_STORAGE_SLOT_SKIPPED].includes(code);
+    default:
+      return false;
+  }
+}