Quick fail e2e test commit/PR workflows on fail of ts-backend-check

[andrewtavis]

Terms

• I have searched open and closed feature requests
• I agree to follow activist's Code of Conduct

Description

Note

This issue is blocked until ts-backend-check is integrated into the activist dev env and the ci_ts_backend_check.yaml workflow is functioning.

ts-backend-check will give the activist team a very early understanding that there are inconsistencies between the backend and frontend. If the workflow fails, then we should also cancel any running e2e commit or PR workflows as there almost certainly will be a fail within the end to end tests. This will function similarly to fail-fast: true when multiple environments are being ran in workflows, and a fail of one triggers a cancel of the others. Note that we would like the ci_ts_backend_check.yaml workflow to continue to be a stand alone workflow, so we'll need to investigate how to link workflows and cancel one when another fails.

Note: For this we can also make the workflows dependent on the ts-backend-check workflow passing.

Contribution

Happy to support on this once we get tsbc up and running!

[aasimsyed]

Could we invert this from "cancel e2e when the check fails" to "don't start e2e until the check passes"? If the check job is extracted into a workflow_call reusable workflow, ci_ts_backend_check.yaml stays standalone as a thin wrapper (same name/triggers), and both e2e workflows call it as a cheap first job with needs: gating the expensive one. Failing PRs go red on the check itself in ~2 minutes and e2e is skipped, no actions: write, no run-correlation script, no cancellation races, and e2e gets protected even on PRs whose paths wouldn't trigger the standalone check. The remaining true cancellation case (new push superseding a running e2e) is covered natively by concurrency: cancel-in-progress: true, which the e2e workflows currently don't set. Happy to PR this if the approach sounds right.

[andrewtavis]

I totally agree that we should not start e2e until the checks pass, @aasimsyed :) I'd had this in mind when writing it. We haven't adopted ts-backend-check yet, but I guess we could already set up the e2e tests to wait for that workflow. Or we can finalize this once we're done integrating it 😊

[andrewtavis]

CC @Narendhraprasth for ts-backend-check related issues :)