From fbfb798a4254e5288a9087a8def00f873fb129a5 Mon Sep 17 00:00:00 2001 From: Yagiz Nizipli Date: Sat, 8 Mar 2025 12:41:13 -0500 Subject: [PATCH 1/3] apply new urlpattern tests --- tests/wpt/urlpatterntestdata.json | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/tests/wpt/urlpatterntestdata.json b/tests/wpt/urlpatterntestdata.json index 18a696d7f..7a3f874d2 100644 --- a/tests/wpt/urlpatterntestdata.json +++ b/tests/wpt/urlpatterntestdata.json @@ -1146,6 +1146,7 @@ }, { "pattern": [{ "protocol": "http", "port": "100000" }], + "inputs": [{ "protocol": "http", "port": "100000" }], "expected_obj": "error" }, { @@ -2400,6 +2401,11 @@ "pattern": [{ "hostname": "bad]hostname" }], "expected_obj": "error" }, + { + "pattern": [{ "hostname": "bad\\\\hostname" }], + "inputs": [{ "hostname": "badhostname" }], + "expected_match": null + }, { "pattern": [{ "hostname": "bad^hostname" }], "expected_obj": "error" @@ -2408,6 +2414,27 @@ "pattern": [{ "hostname": "bad|hostname" }], "expected_obj": "error" }, + { + "pattern": [{ "hostname": "bad\nhostname" }], + "inputs": [{ "hostname": "badhostname" }], + "expected_match": { + "hostname": { "input": "badhostname", "groups": {} } + } + }, + { + "pattern": [{ "hostname": "bad\rhostname" }], + "inputs": [{ "hostname": "badhostname" }], + "expected_match": { + "hostname": { "input": "badhostname", "groups": {} } + } + }, + { + "pattern": [{ "hostname": "bad\thostname" }], + "inputs": [{ "hostname": "badhostname" }], + "expected_match": { + "hostname": { "input": "badhostname", "groups": {} } + } + }, { "pattern": [{}], "inputs": ["https://example.com/"], From d4e9533ca3c9773cd25cb5185da16fbbc57d74d2 Mon Sep 17 00:00:00 2001 From: Yagiz Nizipli Date: Sat, 8 Mar 2025 12:48:05 -0500 Subject: [PATCH 2/3] add more tests that succeed with std::regex provider --- tests/wpt/urlpatterntestdata.json | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/tests/wpt/urlpatterntestdata.json b/tests/wpt/urlpatterntestdata.json index 7a3f874d2..df80afec8 100644 --- a/tests/wpt/urlpatterntestdata.json +++ b/tests/wpt/urlpatterntestdata.json @@ -1115,6 +1115,28 @@ "hostname": { "input": "xn--caf-dma.com", "groups": {}} } }, + { + "pattern": [{"pathname":":a\uDB40\uDD00b"}], + "inputs": [], + "expected_obj": { + "pathname": ":a\uDB40\uDD00b" + }, + "expected_match": null + }, + { + "pattern": [{"pathname":"test/:a\uD801\uDC50b"}], + "inputs": [{"pathname":"test/foo"}], + "expected_obj": { + "pathname": "test/:a\uD801\uDC50b" + }, + "expected_match": { + "pathname": { "input": "test/foo", "groups": { "a\uD801\uDC50b": "foo" }} + } + }, + { + "pattern": [{"pathname":":\uD83D\uDEB2"}], + "expected_obj": "error" + }, { "pattern": [{ "port": "" }], "inputs": [{ "protocol": "http", "port": "80" }], @@ -2824,5 +2846,10 @@ "search": { "input": "q=*&v=?&hmm={}&umm=()", "groups": {} }, "hash": { "input": "foo", "groups": {} } } + }, + { + "pattern": [{ "pathname": "/([[a-z]--a])" }], + "inputs": [{ "pathname": "/a" }], + "expected_match": null } ] From 152d87a30f9b4a4ca97fb951932ba6959c51f579 Mon Sep 17 00:00:00 2001 From: Yagiz Nizipli Date: Sat, 8 Mar 2025 12:51:32 -0500 Subject: [PATCH 3/3] remove test that fails with windows --- tests/wpt/urlpatterntestdata.json | 5 ----- 1 file changed, 5 deletions(-) diff --git a/tests/wpt/urlpatterntestdata.json b/tests/wpt/urlpatterntestdata.json index df80afec8..b1227599c 100644 --- a/tests/wpt/urlpatterntestdata.json +++ b/tests/wpt/urlpatterntestdata.json @@ -2846,10 +2846,5 @@ "search": { "input": "q=*&v=?&hmm={}&umm=()", "groups": {} }, "hash": { "input": "foo", "groups": {} } } - }, - { - "pattern": [{ "pathname": "/([[a-z]--a])" }], - "inputs": [{ "pathname": "/a" }], - "expected_match": null } ]