New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For run_command, not all output ends in \n\r #18

Open

makermelissa opened this issue Mar 10, 2023 · 0 comments

Collaborator

makermelissa commented Mar 10, 2023

For instance, when packages are downloaded, the output line should only have a \r in order to update the percentage done. However, https://github.com/adafruit/Adafruit_Python_Shell/blob/main/adafruit_shell.py#L95 and https://github.com/adafruit/Adafruit_Python_Shell/blob/main/adafruit_shell.py#L92 always print a \n\r resulting in larger packages that were supposed to update a percent actually appear on separate lines. It's not super important, but would make this library better match the actual command output better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment