Incompatible with RP2040/RP2350 Earle Philhower Core v4.4.2 - Conflicting defines as now using upstream SDFat

[tyeth]

Operating System

Windows 11

IDE version

2.3.2

Board

picow

BSP version

4.4.2

SPIFlash Library version

latest

Sketch

Wippersnapper: https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/

What happened ?

This is from a users error in discord, but it's basically identical:

In file included from C:\Users\convo\Documents\Arduino\gettingTheScreenToWork\gettingTheScreenToWork.ino:3:
c:\Users\convo\Documents\Arduino\libraries\Adafruit_SPIFlash\src/Adafruit_SPIFlash.h:37:2: error: #error USE_BLOCK_DEVICE_INTERFACE must be defined to 1 in SdFatConfig.h. Make sure you use the Adafruit Fork at 'https://github.com/adafruit/SdFat'
   37 | #error USE_BLOCK_DEVICE_INTERFACE must be defined to 1 in SdFatConfig.h. Make sure you use the Adafruit Fork at 'https://github.com/adafruit/SdFat'
      |  ^~~~~
c:\Users\convo\Documents\Arduino\libraries\Adafruit_SPIFlash\src/Adafruit_SPIFlash.h:54:2: error: #error FAT12_SUPPORT must be set to 1 in SdFat SdFatConfig.h. Make sure you use the Adafruit Fork at 'https://github.com/adafruit/SdFat'
   54 | #error FAT12_SUPPORT must be set to 1 in SdFat SdFatConfig.h. Make sure you use the Adafruit Fork at 'https://github.com/adafruit/SdFat'
      |  ^~~~~
exit status 1

Compilation error: exit status 1

How to reproduce ?

Undo adafruit/ci-arduino@cfd8cd7 and kick off Wippersnapper CI build,
or build any adafruit SDFat example with Earle core 4.4.2

Debug Log

No response

Screenshots

No response

[tyeth]

Tagging @caternuson just to keep informed once resolved