Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom board build action doesn't work #10117

Open
Neradoc opened this issue Mar 6, 2025 · 1 comment · May be fixed by #10123
Open

Custom board build action doesn't work #10117

Neradoc opened this issue Mar 6, 2025 · 1 comment · May be fixed by #10123
Labels
bug tooling
Milestone
Long term

Comments

@Neradoc
Copy link

Neradoc commented Mar 6, 2025

Trying to make a custom build with the custom build action, I get a failure, with the following error:

Run make -j4 $FLAGS BOARD="$BOARD" DEBUG=$DEBUG TRANSLATION="$TRANSLATION"
  make -j4 $FLAGS BOARD="$BOARD" DEBUG=$DEBUG TRANSLATION="$TRANSLATION"
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.13.2/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.13.2/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.13.2/x64
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.13.2/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.13.2/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.13.2/x64/lib
    TRANSLATION: en_US
    BOARD: adafruit_feather_esp32s3_reverse_tft
    FLAGS: 
    DEBUG: 0
make: *** No targets specified and no makefile found.  Stop.
Error: Process completed with exit code 2.

This seems to be caused by #10026 which removed board-to-port from deps/ports/action.yml requiring instead to input the port, without adding a port entry in the custom action. Personally I would prefer NOT to add more complexity to the custom build action form and instead revert to the previous behavior, or to find the port as before if absent.
@Neradoc Neradoc mentioned this issue Mar 6, 2025
Merged
@tannewt tannewt added this to the Long term milestone Mar 6, 2025
@tannewt
Copy link
Member

tannewt commented Mar 6, 2025

Here is the part to add back:

    - name: Board to port
      id: board-to-port
      run: |
        PORT=$(find ports/*/boards/ -type d -name ${{ inputs.board }} | sed 's/^ports\///g;s/\/boards.*//g')
        if [ -z $PORT ]; then (exit 1); else echo >> $GITHUB_OUTPUT "port=$PORT"; fi
      shell: bash

I would only use this for the build action. The rest doesn't need it. Also note that I removed this because it won't work for the zephyr port because it nests boards under an addition vendor directory. The board ids are then <vendor>_<board name>. This script wouldn't find it. A newer python script would be better.

@Neradoc Neradoc linked a pull request Mar 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug tooling
Projects
None yet
Milestone
Long term
Development

Successfully merging a pull request may close this issue.

Fix custom build workflow Neradoc/circuitpython
2 participants
@tannewt @Neradoc