Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

horizontal form example is incorrect using sass #185

Open
ArnaudValensi opened this issue Jan 18, 2016 · 2 comments
Open

horizontal form example is incorrect using sass #185

ArnaudValensi opened this issue Jan 18, 2016 · 2 comments

Comments

@ArnaudValensi
Copy link

The following example in the documentation is incorrect using sass:

http://getkickstart.com/docs/3.x/ui/forms/#horizontal

There is no selection like in the source code of the example:

.form_group.form_group-horizontal > * {
    vertical-align: middle;
    margin-right: 5px;
    display: inline-block;
}

So, no display: inline-block is applied, so the result appear vertically instead of horizontally.

Is there a simple solution?

@ArnaudValensi
Copy link
Author

Sorry, it is working, my bad.

@ArnaudValensi
Copy link
Author

Actually there is a problem, the example in the doc should add

form .group {
  @include form_group('horizontal');
}

instead of:

.group {
  @include form_group('horizontal');
}

If we don't select form .group, the specificity is too low and the default input configuration will win. It contains:

margin: 0;
display: block;
...

so it stays vertical.

@ArnaudValensi ArnaudValensi reopened this Jan 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant