Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavBar Responsive Collapse items not shown in Chrome and Firefox #193

Open
panosdim opened this issue Sep 15, 2016 · 7 comments
Open

NavBar Responsive Collapse items not shown in Chrome and Firefox #193

panosdim opened this issue Sep 15, 2016 · 7 comments

Comments

@panosdim
Copy link

panosdim commented Sep 15, 2016

The example code

<div class="navbar navbar-collapse" data-ks-navbar>
  <nav>
    <ul>
      <!-- This will be the title and
           the responsive collapse button -->
      <li class="navbar-title">
        <h1>Acme Corp</h1>
        <button role="button">=</button>
      </li>

      <!-- These are the collapsed navigation
           items. -->

      <li>
        <a href="/products/">Products</a>
      </li>
      <li>
        <a href="/blog/">Blog</a>
      </li>
    </ul>
  </nav>
<div>

Is not shown the collapse button in firefox and chrome when i enable a tablet or mobile layout in Developer Tools.

@asif-mahmud
Copy link

very similar problem here. i called k$.nav('.navbar'); yet the problem stays.

@asif-mahmud
Copy link

asif-mahmud commented Dec 22, 2016

solved with a new problem. my navbar block -

 <div class="navbar" data-ks-navbar>
    <nav>
        <ul>
              <li class="navbar-title"><button role="button>=</button></li>
              <li><a href="#">HOME</a></li>
        </ul>
   </nav>
</div>

loaded kickstart.min.js and after that -

<script>
document.addEventListener('DOMContentLoaded', function () {
    $k.nav('.navbar');
} );
</script>

not k$ as in the documentation. now it's working but getting a console error -

Uncaught ReferenceError: $k is not defined

@adamjgrant
Copy link
Owner

adamjgrant commented Dec 22, 2016 via email

@adamjgrant
Copy link
Owner

adamjgrant commented Dec 22, 2016 via email

@asif-mahmud
Copy link

i tried 3 styles -

$k.$('.navbar').navbar(); //works but gives a console error !

k$.nav('.navbar'); // doesn't work. clicking the hamburger doesn't drop down the links

k$.$('.navbar').navbar(); // works

@asif-mahmud
Copy link

BTW i have using kickstart-node version 3.0.75

@asif-mahmud
Copy link

Okay, it's working just fine. checked in chrome, firefox.

you were right, no need to use js for it.

great framework. using with sass and gulp makes it really small. why didnt i find it earlier !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants