Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Microsoft Edge #70

Open
TrevorSayre opened this issue May 9, 2017 · 0 comments
Open

Add support for Microsoft Edge #70

TrevorSayre opened this issue May 9, 2017 · 0 comments

Comments

@TrevorSayre
Copy link

The command to open a URI in Microsoft Edge is:
start microsoft-edge:http://www.google.com

Problematically, the method used to open a URI in this package is to use the stored command and append a space and the URI:

if pluginSettings["baseCommand"]:
  command = "%s %s" % (pluginSettings["baseCommand"], fileToOpen.decode().encode(sys.getfilesystemencoding()) if self._pythonVersion < 3 else fileToOpen,)

The command for Microsoft Edge does not work with a space between the command and the URI, so a special case will need to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant