Skip to content
This repository was archived by the owner on Feb 15, 2024. It is now read-only.

Commit a157dab

Browse files
DaespenDaespen
authored
Refactors maven pom.xml files (#29)
- Moves maven compiler version to parent - Moves junit and log-api dependencies to parent - Completes dependency and plugin version definitions - Removes redundant dependency declarations
1 parent 0aebe13 commit a157dab

File tree

9 files changed

+172
-355
lines changed

9 files changed

+172
-355
lines changed

‎dataformat-aasx/pom.xml‎

Lines changed: 2 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010
</parent>
1111
<artifactId>dataformat-aasx</artifactId>
1212
<name>Asset Administration Shell AASX-Serializer</name>
13+
1314
<dependencies>
1415
<dependency>
1516
<groupId>io.admin-shell.aas</groupId>
1617
<artifactId>dataformat-xml</artifactId>
1718
<version>${revision}</version>
18-
<scope>compile</scope>
1919
</dependency>
2020
<dependency>
2121
<groupId>io.admin-shell.aas</groupId>
@@ -24,51 +24,21 @@
2424
<classifier>tests</classifier>
2525
<scope>test</scope>
2626
</dependency>
27-
<dependency>
28-
<groupId>io.admin-shell.aas</groupId>
29-
<artifactId>model</artifactId>
30-
<version>${revision}</version>
31-
<scope>compile</scope>
32-
</dependency>
3327
<dependency>
3428
<groupId>org.apache.poi</groupId>
3529
<artifactId>poi-ooxml</artifactId>
3630
<version>${poi.version}</version>
3731
</dependency>
38-
<dependency>
39-
<groupId>org.slf4j</groupId>
40-
<artifactId>slf4j-api</artifactId>
41-
<version>${slf4j.version}</version>
42-
</dependency>
43-
<dependency>
44-
<groupId>junit</groupId>
45-
<artifactId>junit</artifactId>
46-
<version>${junit.version}</version>
47-
<scope>test</scope>
48-
</dependency>
4932
<dependency>
5033
<groupId>pl.pragmatists</groupId>
5134
<artifactId>JUnitParams</artifactId>
5235
<version>${junit-params.version}</version>
5336
<scope>test</scope>
54-
</dependency>
37+
</dependency>
5538
<dependency>
5639
<groupId>commons-io</groupId>
5740
<artifactId>commons-io</artifactId>
5841
<version>${commons-io.version}</version>
5942
</dependency>
6043
</dependencies>
61-
<build>
62-
<plugins>
63-
<plugin>
64-
<groupId>org.apache.maven.plugins</groupId>
65-
<artifactId>maven-compiler-plugin</artifactId>
66-
<version>3.8.1</version>
67-
<configuration>
68-
<source>11</source>
69-
<target>11</target>
70-
</configuration>
71-
</plugin>
72-
</plugins>
73-
</build>
7444
</project>

‎dataformat-aml/pom.xml‎

Lines changed: 8 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -10,23 +10,12 @@
1010
</parent>
1111
<artifactId>dataformat-aml</artifactId>
1212
<name>Asset Administration Shell AutomationML-Serializer</name>
13+
1314
<dependencies>
14-
<dependency>
15-
<groupId>io.admin-shell.aas</groupId>
16-
<artifactId>model</artifactId>
17-
<version>${revision}</version>
18-
<scope>compile</scope>
19-
</dependency>
2015
<dependency>
2116
<groupId>io.admin-shell.aas</groupId>
2217
<artifactId>dataformat-core</artifactId>
2318
<version>${revision}</version>
24-
<scope>compile</scope>
25-
</dependency>
26-
<dependency>
27-
<groupId>org.slf4j</groupId>
28-
<artifactId>slf4j-api</artifactId>
29-
<version>${slf4j.version}</version>
3019
</dependency>
3120
<dependency>
3221
<groupId>javax.xml.bind</groupId>
@@ -36,25 +25,19 @@
3625
<dependency>
3726
<groupId>xerces</groupId>
3827
<artifactId>xercesImpl</artifactId>
39-
<version>2.12.1</version>
28+
<version>${xerces.version}</version>
4029
<exclusions>
41-
<exclusion>
42-
<artifactId>xml-apis</artifactId>
43-
<groupId>xml-apis</groupId>
44-
</exclusion>
45-
</exclusions>
30+
<exclusion>
31+
<artifactId>xml-apis</artifactId>
32+
<groupId>xml-apis</groupId>
33+
</exclusion>
34+
</exclusions>
4635
</dependency>
4736
<dependency>
4837
<groupId>org.eclipse.persistence</groupId>
4938
<artifactId>org.eclipse.persistence.moxy</artifactId>
5039
<version>${moxy.version}</version>
5140
</dependency>
52-
<dependency>
53-
<groupId>junit</groupId>
54-
<artifactId>junit</artifactId>
55-
<version>${junit.version}</version>
56-
<scope>test</scope>
57-
</dependency>
5841
<dependency>
5942
<groupId>net.codesup.util</groupId>
6043
<artifactId>jaxb2-rich-contract-plugin</artifactId>
@@ -75,35 +58,11 @@
7558
<dependency>
7659
<groupId>com.google.inject</groupId>
7760
<artifactId>guice</artifactId>
78-
<version>5.0.1</version>
61+
<version>${guice.version}</version>
7962
</dependency>
8063
</dependencies>
8164
<build>
8265
<plugins>
83-
<plugin>
84-
<groupId>org.codehaus.mojo</groupId>
85-
<artifactId>flatten-maven-plugin</artifactId>
86-
<version>${plugin.flatten.version}</version>
87-
<configuration>
88-
<updatePomFile>true</updatePomFile>
89-
</configuration>
90-
<executions>
91-
<execution>
92-
<id>flatten</id>
93-
<phase>process-resources</phase>
94-
<goals>
95-
<goal>flatten</goal>
96-
</goals>
97-
</execution>
98-
<execution>
99-
<id>flatten.clean</id>
100-
<phase>clean</phase>
101-
<goals>
102-
<goal>clean</goal>
103-
</goals>
104-
</execution>
105-
</executions>
106-
</plugin>
10766
<plugin>
10867
<groupId>org.apache.cxf</groupId>
10968
<artifactId>cxf-xjc-plugin</artifactId>

‎dataformat-core/pom.xml‎

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -16,24 +16,17 @@
1616
<groupId>io.admin-shell.aas</groupId>
1717
<artifactId>model</artifactId>
1818
<version>${model.version}</version>
19-
<scope>compile</scope>
2019
</dependency>
2120
<dependency>
2221
<groupId>com.fasterxml.jackson.core</groupId>
2322
<artifactId>jackson-annotations</artifactId>
2423
<version>${jackson.version}</version>
25-
<scope>compile</scope>
2624
</dependency>
2725
<dependency>
2826
<groupId>com.fasterxml.jackson.core</groupId>
2927
<artifactId>jackson-databind</artifactId>
3028
<version>${jackson.version}</version>
3129
</dependency>
32-
<dependency>
33-
<groupId>org.slf4j</groupId>
34-
<artifactId>slf4j-api</artifactId>
35-
<version>${slf4j.version}</version>
36-
</dependency>
3730
<dependency>
3831
<groupId>io.github.classgraph</groupId>
3932
<artifactId>classgraph</artifactId>
@@ -52,24 +45,10 @@
5245
</dependencies>
5346
<build>
5447
<plugins>
55-
<plugin>
56-
<groupId>org.apache.maven.plugins</groupId>
57-
<artifactId>maven-compiler-plugin</artifactId>
58-
<version>3.8.1</version>
59-
<configuration>
60-
<source>11</source>
61-
<target>11</target>
62-
</configuration>
63-
</plugin>
6448
<plugin>
6549
<groupId>org.apache.maven.plugins</groupId>
6650
<artifactId>maven-jar-plugin</artifactId>
67-
<version>3.1.1</version>
68-
<configuration>
69-
<excludes>
70-
<exclude>**/logback.xml</exclude>
71-
</excludes>
72-
</configuration>
51+
<version>${plugin.jar.version}</version>
7352
<executions>
7453
<execution>
7554
<goals>

‎dataformat-json/pom.xml‎

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,10 @@
1212
<name>Asset Administration Shell JSON-Serializer</name>
1313

1414
<dependencies>
15-
<dependency>
16-
<groupId>io.admin-shell.aas</groupId>
17-
<artifactId>model</artifactId>
18-
<version>${model.version}</version>
19-
<scope>compile</scope>
20-
</dependency>
2115
<dependency>
2216
<groupId>io.admin-shell.aas</groupId>
2317
<artifactId>dataformat-core</artifactId>
2418
<version>${revision}</version>
25-
<scope>compile</scope>
2619
</dependency>
2720
<dependency>
2821
<groupId>io.admin-shell.aas</groupId>
@@ -35,18 +28,12 @@
3528
<groupId>com.fasterxml.jackson.core</groupId>
3629
<artifactId>jackson-annotations</artifactId>
3730
<version>${jackson.version}</version>
38-
<scope>compile</scope>
3931
</dependency>
4032
<dependency>
4133
<groupId>com.fasterxml.jackson.core</groupId>
4234
<artifactId>jackson-databind</artifactId>
4335
<version>${jackson.version}</version>
4436
</dependency>
45-
<dependency>
46-
<groupId>org.slf4j</groupId>
47-
<artifactId>slf4j-api</artifactId>
48-
<version>${slf4j.version}</version>
49-
</dependency>
5037
<dependency>
5138
<groupId>com.networknt</groupId>
5239
<artifactId>json-schema-validator</artifactId>
@@ -57,12 +44,6 @@
5744
<artifactId>classgraph</artifactId>
5845
<version>${classgraph.version}</version>
5946
</dependency>
60-
<dependency>
61-
<groupId>junit</groupId>
62-
<artifactId>junit</artifactId>
63-
<version>${junit.version}</version>
64-
<scope>test</scope>
65-
</dependency>
6647
<dependency>
6748
<groupId>pl.pragmatists</groupId>
6849
<artifactId>JUnitParams</artifactId>
@@ -76,17 +57,4 @@
7657
<scope>test</scope>
7758
</dependency>
7859
</dependencies>
79-
<build>
80-
<plugins>
81-
<plugin>
82-
<groupId>org.apache.maven.plugins</groupId>
83-
<artifactId>maven-compiler-plugin</artifactId>
84-
<version>3.8.1</version>
85-
<configuration>
86-
<source>11</source>
87-
<target>11</target>
88-
</configuration>
89-
</plugin>
90-
</plugins>
91-
</build>
9260
</project>

‎dataformat-rdf/pom.xml‎

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,15 @@
22
<project xmlns="http://maven.apache.org/POM/4.0.0"
33
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
44
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
5+
<modelVersion>4.0.0</modelVersion>
56
<parent>
6-
<artifactId>dataformat-parent</artifactId>
77
<groupId>io.admin-shell.aas</groupId>
8+
<artifactId>dataformat-parent</artifactId>
89
<version>${revision}</version>
910
</parent>
10-
<modelVersion>4.0.0</modelVersion>
11-
1211
<artifactId>dataformat-rdf</artifactId>
1312
<name>Asset Administration Shell RDF-Serializer</name>
1413

15-
<properties>
16-
<maven.compiler.source>11</maven.compiler.source>
17-
<maven.compiler.target>11</maven.compiler.target>
18-
</properties>
19-
2014
<dependencies>
2115
<dependency>
2216
<groupId>io.admin-shell.aas</groupId>
@@ -28,19 +22,11 @@
2822
<artifactId>jena-arq</artifactId>
2923
<version>${jena.version}</version>
3024
</dependency>
31-
<dependency>
32-
<groupId>junit</groupId>
33-
<artifactId>junit</artifactId>
34-
<version>${junit.version}</version>
35-
<scope>test</scope>
36-
</dependency>
3725
<dependency>
3826
<groupId>org.slf4j</groupId>
3927
<artifactId>slf4j-simple</artifactId>
40-
<version>1.7.30</version>
28+
<version>${slf4j.version}</version>
4129
<scope>test</scope>
4230
</dependency>
4331
</dependencies>
44-
45-
4632
</project>

0 commit comments

Comments
 (0)