Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled error in _handleOpenDocumentsChanged #457

Open
GDreyV opened this issue Apr 2, 2019 · 1 comment
Open

Unhandled error in _handleOpenDocumentsChanged #457

GDreyV opened this issue Apr 2, 2019 · 1 comment

Comments

@GDreyV
Copy link

GDreyV commented Apr 2, 2019

When this._generator.getDocumentSettingsForPlugin(id, PLUGIN_ID) is called it does not handle error which might occur if e.g. document Is already closed. In that case generator process restarts and leads to the error in all plugins as they all are working in the same sandbox.
And I guess the same for .setDocumentSettingsForPlugin(settings, PLUGIN_ID).done().

@RealBuddy
Copy link

I confirm, if you open some document and close it too fast, using any other plugin or even script – there gonna be an unhandled exception with "Unknown JavaScript error".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants