[API Design] LinkHandler.getLink: Optional<Link> redundant to Link.isValid #1855
stefanseifert
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
that is redundant and we should use only one of the concepts:
furthermore the model interfaces all just define a
@Nullable
Link - unclear whether invalid means null, or not null with isValid=falsewith the current state it's quite confusing. there is already code where links are consumed always checking both !=null && isValid which is very ugly.
this discussion is taken over from the mailing list where it did not gather any attention (except from @ky940819).
Beta Was this translation helpful? Give feedback.
All reactions