From 0bdc943215733d7ec939d1b73e85c7cf041ee473 Mon Sep 17 00:00:00 2001 From: radhikagpt1208 Date: Tue, 9 Sep 2025 15:23:01 +0530 Subject: [PATCH 1/2] fix: updating lorem-ipsum check name in preflight --- docs/openapi/preflight-api.yaml | 2 +- package.json | 2 +- src/controllers/preflight.js | 2 +- test/controllers/preflight.test.js | 8 ++++---- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/openapi/preflight-api.yaml b/docs/openapi/preflight-api.yaml index ede1945f2..d2aaa9dc2 100644 --- a/docs/openapi/preflight-api.yaml +++ b/docs/openapi/preflight-api.yaml @@ -34,7 +34,7 @@ preflight-jobs: type: array items: type: string - enum: [canonical, links, metatags, body-size, lorem-ipsum, h1-count, readability, accessibility] + enum: [canonical, links, metatags, body-size, 'placeholder "lorem-ipsum" detection', h1-count, readability, accessibility] description: Optional array of specific checks to run. If not provided, all checks will be run. required: - urls diff --git a/package.json b/package.json index f863ae7c5..29064b32d 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,7 @@ "build": "hedy -v --test-bundle", "deploy": "hedy -v --deploy --aws-deploy-bucket=spacecat-prod-deploy --pkgVersion=latest", "deploy-stage": "hedy -v --deploy --aws-deploy-bucket=spacecat-stage-deploy --pkgVersion=latest", - "deploy-dev": "hedy -v --deploy --pkgVersion=latest$CI_BUILD_NUM -l latest --aws-deploy-bucket=spacecat-dev-deploy --cleanup-ci=24h --aws-api vldld6qz1d", + "deploy-dev": "hedy -v --deploy --pkgVersion=latest$CI_BUILD_NUM -l anagarwa --aws-deploy-bucket=spacecat-dev-deploy --cleanup-ci=24h --aws-api vldld6qz1d", "deploy-secrets": "hedy --aws-update-secrets --params-file=secrets/secrets.env", "docs": "npm run docs:lint && npm run docs:build", "docs:build": "npx @redocly/cli build-docs -o ./docs/index.html --config docs/openapi/redocly-config.yaml", diff --git a/src/controllers/preflight.js b/src/controllers/preflight.js index bd399b498..43e9aca33 100644 --- a/src/controllers/preflight.js +++ b/src/controllers/preflight.js @@ -26,7 +26,7 @@ export const AUDIT_CANONICAL = 'canonical'; export const AUDIT_LINKS = 'links'; export const AUDIT_METATAGS = 'metatags'; export const AUDIT_BODY_SIZE = 'body-size'; -export const AUDIT_LOREM_IPSUM = 'lorem-ipsum'; +export const AUDIT_LOREM_IPSUM = 'placeholder "lorem-ipsum" detection'; export const AUDIT_H1_COUNT = 'h1-count'; export const AUDIT_ACCESSIBILITY = 'accessibility'; export const AUDIT_READABILITY = 'readability'; diff --git a/test/controllers/preflight.test.js b/test/controllers/preflight.test.js index 74db80a19..505fb70cb 100644 --- a/test/controllers/preflight.test.js +++ b/test/controllers/preflight.test.js @@ -169,7 +169,7 @@ describe('Preflight Controller', () => { urls: ['https://main--example-site.aem.page/test.html'], step: 'identify', enableAuthentication: true, - checks: ['canonical', 'links', 'metatags', 'body-size', 'lorem-ipsum', 'h1-count', 'accessibility', 'readability'], + checks: ['canonical', 'links', 'metatags', 'body-size', 'placeholder "lorem-ipsum" detection', 'h1-count', 'accessibility', 'readability'], }, jobType: 'preflight', tags: ['preflight'], @@ -218,7 +218,7 @@ describe('Preflight Controller', () => { urls: ['https://main--example-site.aem.page/test.html'], step: 'identify', enableAuthentication: false, - checks: ['canonical', 'links', 'metatags', 'body-size', 'lorem-ipsum', 'h1-count', 'accessibility', 'readability'], + checks: ['canonical', 'links', 'metatags', 'body-size', 'placeholder "lorem-ipsum" detection', 'h1-count', 'accessibility', 'readability'], }, jobType: 'preflight', tags: ['preflight'], @@ -295,7 +295,7 @@ describe('Preflight Controller', () => { const result = await response.json(); expect(result).to.deep.equal({ - message: 'Invalid request: checks must be one of: canonical, links, metatags, body-size, lorem-ipsum, h1-count, accessibility, readability', + message: 'Invalid request: checks must be one of: canonical, links, metatags, body-size, placeholder "lorem-ipsum" detection, h1-count, accessibility, readability', }); }); @@ -353,7 +353,7 @@ describe('Preflight Controller', () => { urls: ['https://main--example-site.aem.page/test.html'], step: 'identify', enableAuthentication: true, - checks: ['canonical', 'links', 'metatags', 'body-size', 'lorem-ipsum', 'h1-count', 'accessibility', 'readability'], + checks: ['canonical', 'links', 'metatags', 'body-size', 'placeholder "lorem-ipsum" detection', 'h1-count', 'accessibility', 'readability'], }, jobType: 'preflight', tags: ['preflight'], From e5596be54060c6c828bf256c241baeb5e63af6fc Mon Sep 17 00:00:00 2001 From: radhikagpt1208 Date: Wed, 10 Sep 2025 11:30:48 +0530 Subject: [PATCH 2/2] fix: reverting to latest deployment --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 29064b32d..f863ae7c5 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,7 @@ "build": "hedy -v --test-bundle", "deploy": "hedy -v --deploy --aws-deploy-bucket=spacecat-prod-deploy --pkgVersion=latest", "deploy-stage": "hedy -v --deploy --aws-deploy-bucket=spacecat-stage-deploy --pkgVersion=latest", - "deploy-dev": "hedy -v --deploy --pkgVersion=latest$CI_BUILD_NUM -l anagarwa --aws-deploy-bucket=spacecat-dev-deploy --cleanup-ci=24h --aws-api vldld6qz1d", + "deploy-dev": "hedy -v --deploy --pkgVersion=latest$CI_BUILD_NUM -l latest --aws-deploy-bucket=spacecat-dev-deploy --cleanup-ci=24h --aws-api vldld6qz1d", "deploy-secrets": "hedy --aws-update-secrets --params-file=secrets/secrets.env", "docs": "npm run docs:lint && npm run docs:build", "docs:build": "npx @redocly/cli build-docs -o ./docs/index.html --config docs/openapi/redocly-config.yaml",