feat: add disable all audits feature #1478
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger no release when merged. |
rpapani
reviewed
Nov 21, 2025
|
|
||
| // Fixes | ||
| /* c8 ignore start */ | ||
| // Fixes - Route wrapper functions not covered as they're tested via E2E/integration tests |
rpapani
reviewed
Nov 21, 2025
| } | ||
| }) | ||
| .on('end', () => { | ||
| /* c8 ignore start */ |
rpapani
reviewed
Nov 21, 2025
| Profiles are defined in the config/profiles.json file.`, | ||
| phrases: [PHRASE], | ||
| usageText: `${PHRASE} {enable/disable} {site} {auditType} for singleURL, | ||
| usageText: `${PHRASE} {enable/disable} {site} {auditType} {profileName} for singleURL, |
Collaborator
There was a problem hiding this comment.
may be better to document all option here, so that users will be aware of what's possible
rpapani
reviewed
Nov 21, 2025
| let auditTypes; | ||
| if (singleAuditType.toLowerCase() === 'all') { | ||
| const profileName = profileNameInput ? profileNameInput.toLowerCase() : 'demo'; | ||
| /* c8 ignore start */ |
Collaborator
There was a problem hiding this comment.
we should cover these lines
rpapani
reviewed
Nov 21, 2025
| ); | ||
| const alreadyEnabled = profileAuditTypes.length - auditTypes.length; | ||
| if (alreadyEnabled > 0) { | ||
| await say(`:information_source: Enabling ${auditTypes.length} disabled audits from profile "${profileName}" (${alreadyEnabled} already enabled): ${auditTypes.join(', ')}`); |
Collaborator
There was a problem hiding this comment.
avoid writing disabled in the slack message
rpapani
reviewed
Nov 21, 2025
|
|
||
| if (isEnableAudit) { | ||
| // Filter to only audits that are currently disabled | ||
| auditTypes = profileAuditTypes.filter( |
tkotthakota-adobe
changed the title
Contributor
Author
|
Opening fresh PR as we want to support only disable all audits as per @rpapani |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.corp.adobe.com/browse/SITES-37053
Tests
https://cq-dev.slack.com/archives/C060T2PPF8V/p1763173755764749