Skip to content

Commit f77d2bf

Browse files
committed
fix(dialog,styles): use latest CSS
1 parent dd2f5af commit f77d2bf

File tree

4 files changed

+34
-46
lines changed

4 files changed

+34
-46
lines changed

packages/dialog/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@
9191
"@spectrum-web-components/underlay": "1.5.0"
9292
},
9393
"devDependencies": {
94-
"@spectrum-css/dialog": "11.0.1"
94+
"@spectrum-css/dialog": "12.1.0"
9595
},
9696
"types": "./src/index.d.ts",
9797
"customElements": "custom-elements.json",

packages/dialog/src/dialog.css

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ governing permissions and limitations under the License.
1111
*/
1212

1313
@import url('./spectrum-dialog.css');
14-
@import url('./dialog-overrides.css');
1514

1615
:host {
1716
--swc-alert-dialog-error-icon-color: var(--spectrum-negative-visual-color);

packages/dialog/src/spectrum-dialog.css

+19-34
Original file line numberDiff line numberDiff line change
@@ -12,47 +12,31 @@ governing permissions and limitations under the License.
1212

1313
/* THIS FILE IS MACHINE GENERATED. DO NOT EDIT */
1414
:host {
15-
--spectrum-dialog-fullscreen-header-text-size: 28px;
16-
--spectrum-dialog-min-inline-size: 288px;
17-
--spectrum-dialog-confirm-small-width: 400px;
18-
--spectrum-dialog-confirm-medium-width: 480px;
19-
--spectrum-dialog-confirm-large-width: 640px;
2015
--spectrum-dialog-confirm-divider-block-spacing-start: var(--spectrum-spacing-300);
2116
--spectrum-dialog-confirm-divider-block-spacing-end: var(--spectrum-spacing-200);
2217
--spectrum-dialog-confirm-description-text-color: var(--spectrum-gray-800);
23-
--spectrum-dialog-confirm-title-text-color: var(--spectrum-gray-900);
24-
--spectrum-dialog-confirm-description-text-line-height: var(--spectrum-line-height-100);
25-
--spectrum-dialog-confirm-title-text-line-height: var(--spectrum-line-height-100);
26-
--spectrum-dialog-heading-font-weight: var(--spectrum-heading-sans-serif-font-weight);
2718
--spectrum-dialog-confirm-description-padding: var(--spectrum-spacing-50);
28-
--spectrum-dialog-confirm-description-margin: calc(var(--spectrum-spacing-50) * -1);
29-
--spectrum-dialog-confirm-footer-padding-top: var(--spectrum-spacing-600);
3019
--spectrum-dialog-confirm-gap-size: var(--spectrum-component-pill-edge-to-text-100);
3120
--spectrum-dialog-confirm-buttongroup-padding-top: var(--spectrum-spacing-600);
3221
--spectrum-dialog-confirm-close-button-size: var(--spectrum-component-height-100);
3322
--spectrum-dialog-confirm-close-button-padding: calc(26px - var(--spectrum-component-bottom-to-text-300));
34-
--spectrum-dialog-confirm-divider-height: var(--spectrum-spacing-50);
35-
}
36-
37-
:host,
38-
:host([size='m']) {
3923
box-sizing: border-box;
40-
inline-size: var(--mod-dialog-confirm-medium-width, var(--spectrum-dialog-confirm-medium-width));
41-
min-inline-size: var(--mod-dialog-min-inline-size, var(--spectrum-dialog-min-inline-size));
24+
inline-size: 480px;
25+
inline-size: var(--mod-dialog-width, var(--mod-dialog-confirm-medium-width, 480px));
26+
min-inline-size: 288px;
27+
min-inline-size: var(--mod-dialog-min-inline-size, 288px);
4228
max-inline-size: 100%;
4329
max-block-size: inherit;
4430
outline: none;
4531
display: flex;
4632
}
4733

48-
.spectrum-Dialog--sizeS,
49-
:host([size='s']) {
50-
inline-size: var(--mod-dialog-confirm-small-width, var(--spectrum-dialog-confirm-small-width));
34+
.spectrum-Dialog--sizeS {
35+
--mod-dialog-width: var(--mod-dialog-confirm-small-width, 400px);
5136
}
5237

53-
:host([size='l']),
5438
.spectrum-Dialog--sizeL {
55-
inline-size: var(--mod-dialog-confirm-large-width, var(--spectrum-dialog-confirm-large-width));
39+
--mod-dialog-width: var(--mod-dialog-confirm-large-width, 640px);
5640
}
5741

5842
::slotted([slot='hero']) {
@@ -67,8 +51,6 @@ governing permissions and limitations under the License.
6751

6852
.grid {
6953
grid-template-columns: var(--mod-dialog-confirm-padding-grid, var(--spectrum-dialog-confirm-padding-grid)) auto 1fr auto minmax(0, auto) var(--mod-dialog-confirm-padding-grid, var(--spectrum-dialog-confirm-padding-grid));
70-
grid-template-rows: auto var(--mod-dialog-confirm-padding-grid, var(--spectrum-dialog-confirm-padding-grid)) auto auto 1fr auto var(--mod-dialog-confirm-padding-grid, var(--spectrum-dialog-confirm-padding-grid));
71-
inline-size: 100%;
7254
grid-template-areas:
7355
'hero hero hero hero hero hero'
7456
'. . . . . .'
@@ -77,14 +59,16 @@ governing permissions and limitations under the License.
7759
'. content content content content .'
7860
'. footer footer buttonGroup buttonGroup .'
7961
'. . . . . .';
62+
grid-template-rows: auto var(--mod-dialog-confirm-padding-grid, var(--spectrum-dialog-confirm-padding-grid)) auto auto 1fr auto var(--mod-dialog-confirm-padding-grid, var(--spectrum-dialog-confirm-padding-grid));
63+
inline-size: 100%;
8064
display: grid;
8165
}
8266

8367
::slotted([slot='heading']) {
8468
font-size: var(--mod-dialog-confirm-title-text-size, var(--spectrum-dialog-confirm-title-text-size));
85-
font-weight: var(--mod-dialog-heading-font-weight, var(--spectrum-dialog-heading-font-weight));
86-
line-height: var(--mod-dialog-confirm-title-text-line-height, var(--spectrum-dialog-confirm-title-text-line-height));
87-
color: var(--mod-dialog-confirm-title-text-color, var(--spectrum-dialog-confirm-title-text-color));
69+
font-weight: var(--mod-dialog-heading-font-weight, var(--spectrum-heading-sans-serif-font-weight));
70+
line-height: var(--mod-dialog-confirm-title-text-line-height, var(--spectrum-line-height-100));
71+
color: var(--mod-dialog-confirm-title-text-color, var(--spectrum-gray-900));
8872
outline: none;
8973
grid-area: heading;
9074
margin: 0;
@@ -121,18 +105,18 @@ governing permissions and limitations under the License.
121105
}
122106

123107
:host([no-divider]) ::slotted([slot='heading']) {
124-
padding-block-end: calc(var(--mod-dialog-confirm-divider-block-spacing-end, var(--spectrum-dialog-confirm-divider-block-spacing-end)) + var(--mod-dialog-confirm-divider-block-spacing-start, var(--spectrum-dialog-confirm-divider-block-spacing-start)) + var(--mod-dialog-confirm-divider-height, var(--spectrum-dialog-confirm-divider-height)));
108+
padding-block-end: calc(var(--mod-dialog-confirm-divider-block-spacing-end, var(--spectrum-dialog-confirm-divider-block-spacing-end)) + var(--mod-dialog-confirm-divider-block-spacing-start, var(--spectrum-dialog-confirm-divider-block-spacing-start)) + var(--mod-dialog-confirm-divider-height, var(--spectrum-spacing-50)));
125109
}
126110

127111
.content {
128112
box-sizing: border-box;
129113
-webkit-overflow-scrolling: touch;
130114
font-size: var(--mod-dialog-confirm-description-text-size, var(--spectrum-dialog-confirm-description-text-size));
131115
font-weight: var(--mod-dialog-confirm-description-font-weight, var(--spectrum-regular-font-weight));
132-
line-height: var(--mod-dialog-confirm-description-text-line-height, var(--spectrum-dialog-confirm-description-text-line-height));
116+
line-height: var(--mod-dialog-confirm-description-text-line-height, var(--spectrum-line-height-100));
133117
color: var(--mod-dialog-confirm-description-text-color, var(--spectrum-dialog-confirm-description-text-color));
134118
padding: calc(var(--mod-dialog-confirm-description-padding, var(--spectrum-dialog-confirm-description-padding)) * 2);
135-
margin: 0 var(--mod-dialog-confirm-description-margin, var(--spectrum-dialog-confirm-description-margin));
119+
margin: 0 var(--mod-dialog-confirm-description-margin, calc(var(--spectrum-spacing-50) * -1));
136120
outline: none;
137121
grid-area: content;
138122
overflow-y: auto;
@@ -142,7 +126,7 @@ governing permissions and limitations under the License.
142126
outline: none;
143127
flex-wrap: wrap;
144128
grid-area: footer;
145-
padding-block-start: var(--mod-dialog-confirm-footer-padding-top, var(--spectrum-dialog-confirm-footer-padding-top));
129+
padding-block-start: var(--mod-dialog-confirm-footer-padding-top, var(--spectrum-spacing-600));
146130
display: flex;
147131
}
148132

@@ -165,7 +149,6 @@ governing permissions and limitations under the License.
165149

166150
:host([dismissable]) .grid {
167151
grid-template-columns: var(--mod-dialog-confirm-padding-grid, var(--spectrum-dialog-confirm-padding-grid)) auto 1fr auto minmax(0, auto) minmax(0, var(--mod-dialog-confirm-close-button-size, var(--spectrum-dialog-confirm-close-button-size))) var(--mod-dialog-confirm-padding-grid, var(--spectrum-dialog-confirm-padding-grid));
168-
grid-template-rows: auto var(--mod-dialog-confirm-padding-grid, var(--spectrum-dialog-confirm-padding-grid)) auto auto 1fr auto var(--mod-dialog-confirm-padding-grid, var(--spectrum-dialog-confirm-padding-grid));
169152
grid-template-areas:
170153
'hero hero hero hero hero hero hero'
171154
'. . . . . closeButton closeButton'
@@ -174,6 +157,7 @@ governing permissions and limitations under the License.
174157
'. content content content content content .'
175158
'. footer footer buttonGroup buttonGroup buttonGroup .'
176159
'. . . . . . .';
160+
grid-template-rows: auto var(--mod-dialog-confirm-padding-grid, var(--spectrum-dialog-confirm-padding-grid)) auto auto 1fr auto var(--mod-dialog-confirm-padding-grid, var(--spectrum-dialog-confirm-padding-grid));
177161
}
178162

179163
:host([dismissable]) .grid .button-group {
@@ -224,7 +208,8 @@ governing permissions and limitations under the License.
224208

225209
:host([mode='fullscreen']) ::slotted([slot='heading']),
226210
:host([mode='fullscreenTakeover']) ::slotted([slot='heading']) {
227-
font-size: var(--mod-dialog-fullscreen-header-text-size, var(--spectrum-dialog-fullscreen-header-text-size));
211+
font-size: 28px;
212+
font-size: var(--mod-dialog-fullscreen-header-text-size, 28px);
228213
}
229214

230215
:host([mode='fullscreen']) .content,

yarn.lock

+14-10
Original file line numberDiff line numberDiff line change
@@ -7238,23 +7238,27 @@ __metadata:
72387238
languageName: node
72397239
linkType: hard
72407240

7241-
"@spectrum-css/dialog@npm:11.0.1":
7242-
version: 11.0.1
7243-
resolution: "@spectrum-css/dialog@npm:11.0.1"
7241+
"@spectrum-css/dialog@npm:12.1.0":
7242+
version: 12.1.0
7243+
resolution: "@spectrum-css/dialog@npm:12.1.0"
72447244
peerDependencies:
7245-
"@spectrum-css/closebutton": ">=5"
7246-
"@spectrum-css/divider": ">=3"
7247-
"@spectrum-css/modal": ">=5"
7248-
"@spectrum-css/tokens": ">=14 || >=15"
7249-
"@spectrum-css/underlay": ">=4"
7245+
"@spectrum-css/closebutton": ">=6.0.0 <7.0.0"
7246+
"@spectrum-css/divider": ">=5.0.0 <6.0.0"
7247+
"@spectrum-css/modal": ">=7.0.0 <8.0.0"
7248+
"@spectrum-css/tokens": ">=16.0.0 <17.0.0"
7249+
"@spectrum-css/underlay": ">=6.0.0 <7.0.0"
72507250
peerDependenciesMeta:
7251+
"@spectrum-css/closebutton":
7252+
optional: true
72517253
"@spectrum-css/divider":
72527254
optional: true
72537255
"@spectrum-css/modal":
72547256
optional: true
7257+
"@spectrum-css/tokens":
7258+
optional: true
72557259
"@spectrum-css/underlay":
72567260
optional: true
7257-
checksum: 10c0/bc164c8a5c5343f647446c1833aaa77470fbb2dde8b375a051570690632dc727b7e3f3a19ea12ceffb42c7ef7d04be1ec74b02d9e80e25ea356161344c0c4fdb
7261+
checksum: 10c0/e6c761eb29e070f5b979dd6925e1b43aa727a24efa0389aa67cad25c1193a6149e1277c6270d0c44c831d6c0c0b2aa1e3c3cec6dde11677567bff756d1090e75
72587262
languageName: node
72597263
linkType: hard
72607264

@@ -8377,7 +8381,7 @@ __metadata:
83778381
version: 0.0.0-use.local
83788382
resolution: "@spectrum-web-components/dialog@workspace:packages/dialog"
83798383
dependencies:
8380-
"@spectrum-css/dialog": "npm:11.0.1"
8384+
"@spectrum-css/dialog": "npm:12.1.0"
83818385
"@spectrum-web-components/alert-dialog": "npm:1.5.0"
83828386
"@spectrum-web-components/base": "npm:1.5.0"
83838387
"@spectrum-web-components/button": "npm:1.5.0"

0 commit comments

Comments
 (0)