From b0e4d552d4f303a0108963bb88ca826875874cb7 Mon Sep 17 00:00:00 2001
From: Helen Le <helenl@adobe.com>
Date: Fri, 11 Apr 2025 13:40:48 -0700
Subject: [PATCH] chore(tabs): update access modifiers, changedProperties type

---
 packages/tabs/src/Tabs.ts         | 11 ++++-------
 packages/tabs/src/TabsOverflow.ts |  7 ++-----
 2 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/packages/tabs/src/Tabs.ts b/packages/tabs/src/Tabs.ts
index 4d1b24ea275..877dcd6803e 100644
--- a/packages/tabs/src/Tabs.ts
+++ b/packages/tabs/src/Tabs.ts
@@ -15,7 +15,6 @@ import {
     CSSResult,
     CSSResultArray,
     html,
-    PropertyValueMap,
     PropertyValues,
     SizedMixin,
     TemplateResult,
@@ -161,7 +160,7 @@ export class Tabs extends SizedMixin(Focusable, { noDefaultSize: true }) {
     private slotEl!: HTMLSlotElement;
 
     @query('#list')
-    private tabList!: HTMLDivElement;
+    protected tabList!: HTMLDivElement;
 
     @property({ reflect: true })
     selected = '';
@@ -178,7 +177,7 @@ export class Tabs extends SizedMixin(Focusable, { noDefaultSize: true }) {
         this.rovingTabindexController.clearElementCache();
     }
 
-    private get tabs(): Tab[] {
+    protected get tabs(): Tab[] {
         return this._tabs;
     }
 
@@ -300,7 +299,7 @@ export class Tabs extends SizedMixin(Focusable, { noDefaultSize: true }) {
         return complete;
     }
 
-    private getNecessaryAutoScroll(index: number): number {
+    protected getNecessaryAutoScroll(index: number): number {
         const selectedTab = this.tabs[index];
         const selectionEnd = selectedTab.offsetLeft + selectedTab.offsetWidth;
         const viewportEnd = this.tabList.scrollLeft + this.tabList.offsetWidth;
@@ -350,9 +349,7 @@ export class Tabs extends SizedMixin(Focusable, { noDefaultSize: true }) {
         }
     }
 
-    protected override updated(
-        changedProperties: PropertyValueMap<this>
-    ): void {
+    protected override updated(changedProperties: PropertyValues<this>): void {
         super.updated(changedProperties);
 
         if (changedProperties.has('selected')) {
diff --git a/packages/tabs/src/TabsOverflow.ts b/packages/tabs/src/TabsOverflow.ts
index bd261144998..01f572bff9e 100644
--- a/packages/tabs/src/TabsOverflow.ts
+++ b/packages/tabs/src/TabsOverflow.ts
@@ -12,7 +12,6 @@ governing permissions and limitations under the License.
 import {
     CSSResultArray,
     html,
-    PropertyValueMap,
     PropertyValues,
     SizedMixin,
     SpectrumElement,
@@ -101,7 +100,7 @@ export class TabsOverflow extends SizedMixin(SpectrumElement) {
         this._updateScrollState();
     }
 
-    private _updateScrollState(): void {
+    protected _updateScrollState(): void {
         const { scrollContent, overflowState } = this;
 
         if (scrollContent) {
@@ -132,9 +131,7 @@ export class TabsOverflow extends SizedMixin(SpectrumElement) {
         tabsElement.scrollTabs(left, 'smooth');
     }
 
-    protected override updated(
-        changedProperties: PropertyValueMap<this>
-    ): void {
+    protected override updated(changedProperties: PropertyValues<this>): void {
         super.updated(changedProperties);
         if (changedProperties.has('dir')) {
             this._updateScrollState();