Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve altitude bin validation read_vpts() and as.vpts() #684

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

adokter
Copy link
Owner

@adokter adokter commented Nov 4, 2024

this PR adds checks for the number of altitude bins and their spacing, and retains profiles only with the most common altitude bin definition (number of bins and bin size). Since current vpts objects can only handle one type of altitude profile, only the most common type is retained.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.35%. Comparing base (d1c6a8e) to head (5fdf406).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
R/as.vpts.R 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #684      +/-   ##
==========================================
+ Coverage   81.87%   82.35%   +0.47%     
==========================================
  Files          61       61              
  Lines        3703     3717      +14     
==========================================
+ Hits         3032     3061      +29     
+ Misses        671      656      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adokter adokter added this to the 0.8.2 milestone Nov 5, 2024
@adokter adokter self-assigned this Nov 5, 2024
@adokter adokter merged commit 9bf2c02 into master Nov 5, 2024
5 checks passed
@adokter adokter deleted the altitude_layer_check branch November 5, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant