Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rhdf5 dependency issue // bioRad scheduled for archiving #688

Closed
adokter opened this issue Jan 6, 2025 · 6 comments
Closed

rhdf5 dependency issue // bioRad scheduled for archiving #688

adokter opened this issue Jan 6, 2025 · 6 comments

Comments

@adokter
Copy link
Owner

adokter commented Jan 6, 2025

@peterdesmet @bart1 @iskandari FYI bioRad is scheduled for archiving on Feb 2 2025, because of issues in bioconductor dependency package rhdf5, see grimbough/rhdf5#154. If you identify a fix please post in that issue.

@peterdesmet
Copy link
Collaborator

Do the issues exist in previous versions of rhdf5? If not, we could specify a version in DESCRIPTION:

rhdf5 (<= x.x.x)

Or is rhdf5 going to be archived on bioconductor? If so, you could install from another source. R-universe is designed for this: https://bioc.r-universe.dev/rhdf5. A user can do this as such:

install.packages("rhdf5", repos = "https://bioc.r-universe.dev")

But I forgot how to specify that in DESCRIPTION though.

@bart1
Copy link
Collaborator

bart1 commented Jan 8, 2025

It seems there is work on the main issue in rhdf5 so I guess that should be resolved this time.

@adokter
Copy link
Owner Author

adokter commented Jan 8, 2025

Fixes to rhdf5 should propagate to bioconductor over the next few days, hopefully that will solve this issue

@grimbough
Copy link

I don't see the "UBSAN" report for the CRAN check on bioRad, so I think the changes I made to rhdf have propagated and been successful.

The offending code has been in rhdf5 for many years, so I guess Prof Ripley has stepped up his tracking and eforcement of these issues for CRAN packages. Something further comes up, please don't hesitate to open another issue with rhdf5.

@adokter
Copy link
Owner Author

adokter commented Jan 15, 2025

Hi @grimbough, thanks so much for your help and quick fix for this, really appreciate it!

You're right, CRAN has been adding more and more checks over the last few years, regularly triggering requests for fixes for code that has been around for a long time. It's sometimes a challenge when the time given to upload a fix is short ...

@adokter
Copy link
Owner Author

adokter commented Jan 15, 2025

fixed by grimbough/rhdf5#154

@adokter adokter closed this as completed Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants