Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making the margin in the SVG output optional #21

Closed
hillstub opened this issue Mar 31, 2024 · 2 comments · May be fixed by #23
Closed

Making the margin in the SVG output optional #21

hillstub opened this issue Mar 31, 2024 · 2 comments · May be fixed by #23

Comments

@hillstub
Copy link

Right now, there seems to be a margin of 1px around the datamatrix when outputting to SVG. Would it be possible to make this optional? (happy to create a pull request)
@adrianschlatter
Copy link
Owner

Many things are possible. What would be the reasoning for having a no-margin option?

@adrianschlatter adrianschlatter closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2024
@denschub
Copy link

I don't want to create a new issue, so I'll just comment here, but

What would be the reasoning for having a no-margin option?

I'm currently using ppf.datamatrix to generate datamatrix codes to print out on a label printer. The printer itself already has a fairly big print margin, so I want the generated code to be as big as possible.

denschub added a commit to denschub/ppf.datamatrix that referenced this issue Jan 25, 2025
@denschub
Add optional flag to disable margins.
7e8c0a0 
Fixes adrianschlatter#21
@denschub denschub mentioned this issue Jan 25, 2025
Open
denschub added a commit to denschub/ppf.datamatrix that referenced this issue Jan 25, 2025
@denschub
Add optional flag to disable margins.
530363c 
Fixes adrianschlatter#21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add optional flag to disable margins. denschub/ppf.datamatrix
3 participants
@denschub @hillstub @adrianschlatter