-
Notifications
You must be signed in to change notification settings - Fork 264
[ENH] Add Working AutoETS algorithm #3253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for contributing to
|
…anging the AIC calculation
…t/aeon into arb/auto_ets_working
…t/aeon into arb/auto_ets_working
…of damped multiplicative trend component
|
I think we can probably optimise this, but other than the point about lags, it lgtm |
TonyBagnall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comment, but not a block at this point
…t/aeon into arb/auto_ets_working
TonyBagnall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, nice


Reference Issues/PRs
Working implementation that supersedes #3032 and #3135
Resolves #3016 by fixing the bug at source
What does this implement/fix? Explain your changes.
Adds Working AutoETS algorithm
Does your contribution introduce a new dependency? If yes, which one?
No
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access