Skip to content

Commit 149fc2c

Browse files
committed
Fix crash setting transform on undefined when layer is destroyed in updateSrc and layer is not yet recreated because image has not loaded yet
1 parent b0148d9 commit 149fc2c

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

src/components/layer.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,8 @@ export var Component = registerComponent('layer', {
222222
if (!this.el.sceneEl.xrSession) { return; }
223223
if (!this.referenceSpace) { return; }
224224
if (this.layerEnabled && !this.layer && (this.el.sceneEl.is('vr-mode') || this.el.sceneEl.is('ar-mode'))) { this.initLayer(); }
225+
// initLayer may not have created the layer if the texture is not loaded yet
226+
if (!this.layer) { return; }
225227
this.updateTransform();
226228
if (this.data.src.complete && (this.pendingCubeMapUpdate || this.loadingScreen || this.visibilityChanged)) { this.loadCubeMapImages(); }
227229
if (!this.needsRedraw && !this.layer.needsRedraw) { return; }

0 commit comments

Comments
 (0)