Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeltaLinkHTTP.retry() without retry mechanism? #195

Open
oliverbrandt opened this issue Nov 2, 2022 · 2 comments
Open

DeltaLinkHTTP.retry() without retry mechanism? #195

oliverbrandt opened this issue Nov 2, 2022 · 2 comments

Comments

@oliverbrandt
Copy link

When looking at https://github.com/afs/rdf-delta/blob/main/rdf-delta-client/src/main/java/org/seaborne/delta/client/DeltaLinkHTTP.java#L122 there is a mismatch between the comments and the parameters on one hand and the implementation on the other hand.

The comments and the parameters hint at a retry functionality which had possibly been intended, where as the code does not contain such a mechanism. Is this due to a change in plans or due to an oversight in not implementing the retry?

@afs
Copy link
Owner

afs commented Nov 3, 2022

It seems that some code has got lost. There was a retry policy but it's not in the codebase now.

@afs
Copy link
Owner

afs commented Nov 9, 2022

This code exists to retrying to get a registration id when a patch server restarts. But registration ids (per instance) have been removed.

This code isn't retrying request otherwise - TCP should be doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants