-
Notifications
You must be signed in to change notification settings - Fork 259
Open
Description
Task list to address #2201 , itemised by what needs to change (with proposed changes), rather than where (too many imports to list!):
-
*.BundlesasBundles -
*.Bundles.RawasRaw -
*.Consequences{.*}asConsequences -
*.Construct.CompositionasComposition -
*.Construct.IdentityasIdentity -
*.DefinitionsasDefinitions -
*.Effectful.TransformerasTransformer -
*.StructuresasStructures -
Data.Nat{.*}asℕQualified import ofData.Natfixing #2280 #2281 -
Data.Integer.Divisibility: this module makes qualified imports from variousData.Natmodules, but it doesn't seem easy to import them all under a single qualified nameℕ, because the structure seems to need to export the constructordividesofData.Nat.Divisibility, leading to a disambiguation error... perhaps this can be renegotiated/refactored viaintroducing a pattern synonym? Qualified imports inData.Nat.Divisibility.CoreData.Integer.Divisibilityfixing #2280 #2294 -
Data.Product.BaseasProduct(orΣ?) Qualified import ofData.Product.Basefixing #2280 #2284 NB Data.Container.* yields non-trivial ambiguities -
Data.Sum.BaseasSum(or⊎?) Qualified import ofData.Sum.Basefixing #2280 #2290 NB Data.Container.* yields non-trivial ambiguities -
Data.X.PropertiesasX, rather thanXₚwithXthe datatype name, not the ASCII module name (as inℕabove) Qualified import ofPropertiesmodules fixing #2280 #2283 NB see the caveats on that PR -
Function.*asFunction -
Relation.Binary.PropositionalEquality{.*}Qualified import ofPropositionalEqualityetc. fixing #2280 #2293 (systematic but terrifyingly pointless) -
Relation.Binary.Reasoning.Setoidas≈-Reasoningby analogy with≡-ReasoningQualified import of reasoning modules fixing #2280 #2282 / Style guide: guideline for-Reasoningmodule imports cf #2282 #2309 -
Relation.Binary.*asBinary -
Relation.Nullary.*asNullary(exceptions forDecidableandNegation?) -
Relation.Unary.*asUnary -
README.*Tidy upREADMEimports #2280 #2313 - ...
TODO: update style-guide to incorporate the conventions:
- final choices of names for
SumandProduct - ...
Things to leave alone:
-
Foreign.* -
System.* - ...
Design decisions/outstanding questions:
- use of Unicode: we had agreed in What names should be used for qualified module imports? #2201 to the use of
ℕas the qualified module name for the (most-?) common cases of importing qualified fromData.Nat.*, and equality as≡fromRelation.Binary.PropositionalEquality.*; but as the list above asks: what about the qualified import names forSumandProduct? - what to do where the style guide recommendations cannot be followed?
NB. Each of the above tasks/associated PRs seems to have one or two 'leftovers', so a final 'mop-up' PR may well be in order once the above list (or a suitable subset) is completed.