Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two failing tests on Linux #321

Open
cclauss opened this issue May 16, 2024 · 1 comment · May be fixed by #294
Open

Fix two failing tests on Linux #321

cclauss opened this issue May 16, 2024 · 1 comment · May be fixed by #294

Comments

@cclauss
Copy link
Contributor

cclauss commented May 16, 2024

In #318, I had to add @pytest.mark.skipif(sys.platform == "linux", reason="'JSON data' not found") to two tests.

It would be great if someone could modify test/python_magic_test.py to fix these tests and remove the TODO and the skipif lines.

    # TODO: Fix this failing test on Ubuntu
    @pytest.mark.skipif(sys.platform == "linux", reason="'JSON data' not found")
    def test_descriptions(self):
        ...

    # TODO: Fix this failing test on Ubuntu
    @pytest.mark.skipif(sys.platform == "linux", reason="'JSON data' not found")
    def test_descriptions_no_soft(self):
        ...

We will need libmagic1 >= v5.44 #327 (comment)

ddelange added a commit to ddelange/python-magic that referenced this issue May 22, 2024
@ddelange
Copy link
Contributor

ddelange commented May 22, 2024

My suspicion (#318 (comment)) was confirmed. ci passes when installing latest libmagic from source on ubuntu-latest. See 8381a96 + 9c5f955 in #294. ci passing on my fork for the latter commit: https://github.com/ddelange/python-magic/actions/runs/9188880947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants