Add missing delete

Signed-off-by: Rafi Wiener <[email protected]>

Author: rafiw

src/infra/nixl_memory_section.cpp

@@ -328,8 +328,10 @@ nixl_status_t nixlLocalSection::serializePartial(nixlSerDes* serializer,
             }
             resp->addDesc((*base)[index]);
         }
-        if (ret != NIXL_SUCCESS)
+        if (ret != NIXL_SUCCESS) {
+            delete resp;
             break;
+        }
         mem_elms_to_serialize.emplace(sec_key, resp);
     }
 

src/plugins/gpunetio/gpunetio_backend.cpp

@@ -345,6 +345,7 @@ nixlDocaEngine::nixlDocaInitNotif (const std::string &remote_agent,
     notif->send_addr = (uint8_t *)calloc (notif->elems_size * notif->elems_num, sizeof (uint8_t));
     if (notif->send_addr == nullptr) {
         NIXL_ERROR << "Can't alloc memory for send notif";
+        delete notif;
         return NIXL_ERR_BACKEND;
     }
     memset (notif->send_addr, 0, notif->elems_size * notif->elems_num);
@@ -404,6 +405,8 @@ nixlDocaEngine::nixlDocaInitNotif (const std::string &remote_agent,
     delete notif->recv_mmap;
     delete notif->recv_barr;
 
+    delete notif;
+
     return NIXL_ERR_BACKEND;
 }
 
@@ -695,6 +698,7 @@ nixlDocaEngine::addRdmaQp (const std::string &remote_agent) {
     return NIXL_SUCCESS;
 
 exit_error:
+    delete rdma_qp;
     return NIXL_ERR_BACKEND;
 }
 
@@ -1050,15 +1054,15 @@ nixlDocaEngine::loadRemoteConnInfo (const std::string &remote_agent,
     nixlDocaConnection conn;
     size_t size = remote_conn_info.size();
     // TODO: eventually std::byte?
-    char *addr = new char[size];
+    auto addr = std::make_unique<char[]>(size);
 
     if (remoteConnMap.find (remote_agent) != remoteConnMap.end()) {
         return NIXL_ERR_INVALID_PARAM;
     }
 
-    nixlSerDes::_stringToBytes ((void *)addr, remote_conn_info, size);
+    nixlSerDes::_stringToBytes((void *)addr.get(), remote_conn_info, size);
 
-    int ret = oob_connection_client_setup (addr, &oob_sock_client);
+    int ret = oob_connection_client_setup(addr.get(), &oob_sock_client);
     if (ret < 0) {
         NIXL_ERROR << "Can't connect to server " << ret;
         return NIXL_ERR_BACKEND;
@@ -1082,8 +1086,6 @@ nixlDocaEngine::loadRemoteConnInfo (const std::string &remote_agent,
 
     close (oob_sock_client);
 
-    delete[] addr;
-
     return NIXL_SUCCESS;
 }
 
@@ -1103,6 +1105,7 @@ nixlDocaEngine::registerMem (const nixlBlobDesc &mem,
             });
     if (it == gdevs.end()) {
         NIXL_ERROR << "Can't register memory for unknown device " << mem.devId;
+        delete priv;
         return NIXL_ERR_INVALID_PARAM;
     }
 
@@ -1137,7 +1140,7 @@ nixlDocaEngine::registerMem (const nixlBlobDesc &mem,
 error:
     delete priv->mem.mmap;
     delete priv->mem.barr;
-
+    delete priv;
     return NIXL_ERR_BACKEND;
 }
 
@@ -1173,16 +1176,16 @@ nixlDocaEngine::loadRemoteMD (const nixlBlobDesc &input,
 
     if (search == remoteConnMap.end()) {
         NIXL_ERROR << "err: remote connection not found remote_agent " << remote_agent;
-        return NIXL_ERR_NOT_FOUND;
+        goto error;
     }
-
     conn = (nixlDocaConnection)search->second;
 
     // directly copy underlying conn struct
     md->conn = conn;
 
     //Empty mmap, filled with imported data
     try {
+        md->mem.mmap = nullptr;
         md->mem.mmap = new nixlDocaMmap();
     } catch (const std::exception &e) {
         goto error;
@@ -1192,11 +1195,12 @@ nixlDocaEngine::loadRemoteMD (const nixlBlobDesc &input,
     if (result != DOCA_SUCCESS) {
         NIXL_ERROR << "Function doca_mmap_create_from_export failed "
                    << doca_error_get_descr (result);
-        return NIXL_ERR_BACKEND;
+        goto error;
     }
 
     /* Remote buffer array */
     try {
+        md->mem.barr = nullptr;
         md->mem.barr = new nixlDocaBarr(md->mem.mmap->mmap, 1, (size_t)size, gdevs[0].second);
     } catch (const std::exception &e) {
         goto error;
@@ -1208,7 +1212,8 @@ nixlDocaEngine::loadRemoteMD (const nixlBlobDesc &input,
 
 error:
     delete md->mem.barr;
-
+    delete md->mem.mmap;
+    delete md;
     return NIXL_ERR_BACKEND;
 }
 
@@ -1246,14 +1251,21 @@ nixlDocaEngine::prepXfer (const nixl_xfer_op_t &operation,
     auto search = qpMap.find (remote_agent);
     if (search == qpMap.end()) {
         NIXL_ERROR << "Can't find remote_agent " << remote_agent;
+        delete treq;
         return NIXL_ERR_INVALID_PARAM;
     }
 
     rdma_qp = search->second;
 
-    if (lcnt != rcnt) return NIXL_ERR_INVALID_PARAM;
+    if (lcnt != rcnt) {
+        delete treq;
+        return NIXL_ERR_INVALID_PARAM;
+    }
 
-    if (lcnt == 0) return NIXL_ERR_INVALID_PARAM;
+    if (lcnt == 0) {
+        delete treq;
+        return NIXL_ERR_INVALID_PARAM;
+    }
 
     if (opt_args->customParam.empty()) {
         stream_id = (xferStream.fetch_add (1) & (nstreams - 1));
@@ -1302,6 +1314,7 @@ nixlDocaEngine::prepXfer (const nixl_xfer_op_t &operation,
         auto search = notifMap.find (remote_agent);
         if (search == notifMap.end()) {
             // NIXL_ERROR << "Can't find notif for remote_agent " << remote_agent;
+            delete treq;
             return NIXL_ERR_INVALID_PARAM;
         }
 

src/plugins/obj/obj_backend.cpp

@@ -159,7 +159,6 @@ nixl_status_t
 nixlObjEngine::deregisterMem(nixlBackendMD *meta) {
     nixlObjMetadata *obj_md = static_cast<nixlObjMetadata *>(meta);
     if (obj_md) {
-        std::unique_ptr<nixlObjMetadata> obj_md_ptr = std::unique_ptr<nixlObjMetadata>(obj_md);
         devIdToObjKey_.erase(obj_md->devId);
     }