Skip to content

DEVICE/API: Remove signal_offset param from nixlGpuPostWriteXferReq #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michal-shalev wants to merge 3 commits into
base: main
Choose a base branch
from
+0 −3
Open

DEVICE/API: Remove signal_offset param from nixlGpuPostWriteXferReq #1064

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a6bf09
DEVICE/API: Remove signal_offset param from nixlGpuPostWriteXferReq
michal-shalev Nov 28, 2025
8398219
Merge branch 'main' into remove-unsupported-signal-offset-param
michal-shalev Dec 1, 2025
791f815
Merge branch 'main' into remove-unsupported-signal-offset-param
michal-shalev Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/api/gpu/ucx/nixl_device.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ nixlGpuPostPartialWriteXferReq(nixlGpuXferReqH req_hndl,
*
* @param req_hndl [in] Request handle.
* @param signal_inc [in] Increment value for the signal. The signal will only be posted if signal_inc != 0.
* @param signal_offset [in] Offset of the signal to be sent.
* @param channel_id [in] Channel ID to use for the transfer.
* @param is_no_delay [in] Whether to use no-delay mode.
* @param xfer_status [out] Status of the transfer. If not null, use @ref
Expand All @@ -209,7 +208,6 @@ template<nixl_gpu_level_t level = nixl_gpu_level_t::THREAD>
__device__ nixl_status_t
nixlGpuPostWriteXferReq(nixlGpuXferReqH req_hndl,
uint64_t signal_inc,
size_t signal_offset,
unsigned channel_id = 0,
bool is_no_delay = true,
nixlGpuXferStatusH *xfer_status = nullptr) {
Expand All @@ -218,7 +216,6 @@ nixlGpuPostWriteXferReq(nixlGpuXferReqH req_hndl,
ucs_status_t status =
ucp_device_put_multi<static_cast<ucs_device_level_t>(level)>(params.mem_list,
signal_inc,
signal_offset,
channel_id,
params.flags,
params.ucp_request);
Expand Down