PGSU not available for conda

[csadorf]

The pgsu dependency cannot be installed with conda: https://github.com/aiidateam/aiida-core/runs/566297364?check_suite_focus=true !

@ltalirz Can you create a conda-forge package, please?
@sphuber Can you make sure to add me as a reviewer when dependencies are changed? I'm not sure why the codeowner file did not trigger my review.

[chrisjsewell]

This is what I mentioned in #3613 (comment). I still feel you shouldn't be "allowed" to merge to develop until .github/workflows/test-install.yml passes, rather than these tests only being triggered after the merge?

[csadorf]

@chrisjsewell It actually should have been triggered:

aiida-core/.github/workflows/test-install.yml

Lines 4 to 11 in 5da7120

	push:
	paths:
	- 'setup.*'
	- 'environment.yml'
	- '**/requirements*.txt'
	- 'pyproject.toml'
	- 'util/dependency_management.py'
	- '.github/workflows/test-install.yml'

I assume it didn't because it was a pull request? I'm still a bit confused about the github actions push trigger.

[chrisjsewell]

I assume it didn't because it was a pull request?

Yep exactly (as I understand it) push only trigger when a commit is made to a branch of aiidateam/aiida-core (not forks), rather than pull-request trigger when commits are made to any forks/branches associated with open PRs.

[ltalirz]

the PR is open since 2 days ago conda-forge/staged-recipes#11226
waiting for it to be merged

[csadorf]

I assume it didn't because it was a pull request?

Yep exactly (as I understand it) push only trigger when a commit is made to a branch of aiidateam/aiida-core (not forks), rather than pull-request trigger when commits are made to any forks/branches associated with open PRs.

@chrisjsewell So no other way than to just duplicate everything? Or should we just replace push with pull_request considering the use case here?

[chrisjsewell]

@chrisjsewell So no other way than to just duplicate everything? Or should we just replace push with pull_request considering the use case here?

Given that its also be run as a cron job anyway, I'd just replace with pull_request.

FYI here's a related GitHub Forum Post, that I've looked at before in relation to other projects. Its annoying that if you make a PR from a branch (not fork), you end up with duplicates of all the tests, but it looks like there is no good solution for that.

[ltalirz]

fixed https://github.com/conda-forge/pgsu-feedstock