Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FirecrestScheduler could inhereit from SlurmScheduler #42

Open
khsrali opened this issue Jul 15, 2024 · 0 comments
Open

FirecrestScheduler could inhereit from SlurmScheduler #42

khsrali opened this issue Jul 15, 2024 · 0 comments

Comments

@khsrali
Copy link
Contributor

khsrali commented Jul 15, 2024

As discussed with @agoscinski, it would have make more sense if FirecrestScheduler was inheriting from SlurmScheduler instead of Scheduler.

However currently this is is more challenging after (even before) merged PR #6043. Because now SlurmScheduler is inheriting from BashCliScheduler, which is designed for schedulers that are able to execute commands.

Right now, we copy paste manually a few functions of SlurmScheduler that we need.

Although the code remains functional, one could evaluate pros and cons on this, if relevant propose changes in aiida-core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@khsrali