-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no_proxy setting is not honored in connector #8549
Comments
If you want us to look at this, you'll probably have to create a test (e.g. in test_proxy.py or test_proxy_functional.py) that demonstrates the issue. |
Sorry, I am no python dev. I understand the |
Well step 1 of your reproducer pretty much rules out the chance of anybody looking at this.. |
Sorry again, I am just the indirect user of that library. And this is the only option for me to reproduce it. But if you have a look to the It may happen, that with having fixed it there, this may not be sufficient from top-level point of view (kubernetes cluster), yet. |
To put that into context, this project is over a decade old and written by hundreds of contributors. Speaking for myself, I have never even used the proxy functionality in this project, nevermind written any of it. I have no idea how this NO_PROXY envvar is supposed to work (searching for it in the code shows a mention in the docs and a couple of tests in test_helpers.py, but no reference in the code itself), and don't know how to verify this behaviour. I'm just telling you what needs to happen to significantly increase your chances of someone else looking at the issue. Unless an issue is directly affecting a maintainer (who is a volunteer with limited time), it's unlikely that they will spend hours trying to figure out your problem. If you can provide a test (or failing that, a copy/paste reproducer that can be immediately run locally), there is a good chance someone will look at fixing it. If not, chances are slim. |
Describe the bug
We try to connect to a kubernetes cluster, residing behind a proxy that is needed for downloading external resources, but not for connecting to the cluster.
In the proxy log we observe access to
10.152.183.1:443
, which is the cluster's api server, and whose network is excluded using no_proxy/NO_PROXY environment.We narrowed it doen to (at least)
aiohttp/aiohttp/connector.py
Line 928 in a561fa9
Here it is asked only, if there is set a proxy. Not considering the target to establish the connection to. And thus not considering the exclusion for the k9s api server address.
To Reproduce
You should be able to test much easier, here is just what we used for testing:
10.152.183.0/24
(with default k9s networking)Python Version
Python 3.11.6
aiohttp Version
aiohttp 3.9.5
multidict Version
multidict 6.0.5
yarl Version
yarl 1.9.4
OS
Linux testing-0 5.15.0-116-generic #126-Ubuntu SMP Mon Jul 1 10:14:24 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Related component
Client
Additional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: