diff --git a/.github/workflows/kafka-connect-ci.yml b/.github/workflows/kafka-connect-ci.yml index 121929d9d979..df4d00de7a59 100644 --- a/.github/workflows/kafka-connect-ci.yml +++ b/.github/workflows/kafka-connect-ci.yml @@ -98,6 +98,12 @@ jobs: - uses: actions/upload-artifact@v4 if: failure() with: - name: test logs + name: ${{ runner.os }}-${{ matrix.jvm }}-test-logs path: | **/build/testlogs + - uses: actions/upload-artifact@v4 + if: failure() + with: + name: ${{ runner.os }}-${{ matrix.jvm }}-test-reports + path: | + **/build/reports/tests/** diff --git a/aws/src/main/java/org/apache/iceberg/aws/StaticCredentialsProvider.java b/aws/src/main/java/org/apache/iceberg/aws/StaticCredentialsProvider.java index caa2e3b0c91e..0c2b3fc2b45e 100644 --- a/aws/src/main/java/org/apache/iceberg/aws/StaticCredentialsProvider.java +++ b/aws/src/main/java/org/apache/iceberg/aws/StaticCredentialsProvider.java @@ -33,8 +33,9 @@ * *

This code was copied from the original to add the create() factory method required by Iceberg. * - * @link StaticCredentialsProvider.java + * @see AWS + * StaticCredentialsProvider.java */ @SdkPublicApi public final class StaticCredentialsProvider implements AwsCredentialsProvider { @@ -48,14 +49,14 @@ private StaticCredentialsProvider(AwsCredentials credentials) { this.credentials = withProviderName(credentials); } - private AwsCredentials withProviderName(AwsCredentials credentials) { - if (credentials instanceof AwsBasicCredentials) { - return ((AwsBasicCredentials) credentials).copy(c -> c.providerName(PROVIDER_NAME)); + private AwsCredentials withProviderName(AwsCredentials candidate) { + if (candidate instanceof AwsBasicCredentials) { + return ((AwsBasicCredentials) candidate).copy(c -> c.providerName(PROVIDER_NAME)); } - if (credentials instanceof AwsSessionCredentials) { - return ((AwsSessionCredentials) credentials).copy(c -> c.providerName(PROVIDER_NAME)); + if (candidate instanceof AwsSessionCredentials) { + return ((AwsSessionCredentials) candidate).copy(c -> c.providerName(PROVIDER_NAME)); } - return credentials; + return candidate; } /** Create a credentials provider that always returns the provided set of credentials. */