Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build of Vue.js 3 app needs scss Rollup plugin (should not) #16

Closed
akauppi opened this issue Jun 27, 2020 · 3 comments
Closed

Build of Vue.js 3 app needs scss Rollup plugin (should not) #16

akauppi opened this issue Jun 27, 2020 · 3 comments
Labels
back-burner Something to keep an eye on, but not actively engage packages/app Involves the package/app

Comments

@akauppi
Copy link
Owner

akauppi commented Jun 27, 2020 •
edited
Loading

With pr-prod branch:

$ npx rollup -c rollup.config.prod.js 

src/main.js → public/dist/...
[!] Error: Unexpected token (Note that you need plugins to import files that are not JavaScript)
src/App.vue?vue&type=style&index=0&id=7ba5bd90&scoped=true&lang.css (2:0)
Error: Unexpected token (Note that you need plugins to import files that are not JavaScript)
    at error (/Users/asko/Git/GroundLevel-es6-firebase-web/node_modules/rollup/dist/shared/rollup.js:5154:30)
    at Module.error (/Users/asko/Git/GroundLevel-es6-firebase-web/node_modules/rollup/dist/shared/rollup.js:9592:16)
    at tryParse (/Users/asko/Git/GroundLevel-es6-firebase-web/node_modules/rollup/dist/shared/rollup.js:9506:23)
    at Module.setSource (/Users/asko/Git/GroundLevel-es6-firebase-web/node_modules/rollup/dist/shared/rollup.js:9890:30)
    at ModuleLoader.addModuleSource (/Users/asko/Git/GroundLevel-es6-firebase-web/node_modules/rollup/dist/shared/rollup.js:17749:20)
    at ModuleLoader.fetchModule (/Users/asko/Git/GroundLevel-es6-firebase-web/node_modules/rollup/dist/shared/rollup.js:17803:9)
    at async Promise.all (index 2)
    at ModuleLoader.fetchStaticDependencies (/Users/asko/Git/GroundLevel-es6-firebase-web/node_modules/rollup/dist/shared/rollup.js:17827:34)
    at async Promise.all (index 0)
    at ModuleLoader.fetchModule (/Users/asko/Git/GroundLevel-es6-firebase-web/node_modules/rollup/dist/shared/rollup.js:17804:9)
    at async Promise.all (index 3)
    at ModuleLoader.fetchStaticDependencies (/Users/asko/Git/GroundLevel-es6-firebase-web/node_modules/rollup/dist/shared/rollup.js:17827:34)
    at async Promise.all (index 0)
    at ModuleLoader.fetchModule (/Users/asko/Git/GroundLevel-es6-firebase-web/node_modules/rollup/dist/shared/rollup.js:17804:9)
    at async Promise.all (index 0)

What is causing this?
akauppi added a commit that referenced this issue Jun 27, 2020
@akauppi
Unsure how to fix; see #16
e61966d
@akauppi akauppi changed the title How to build Vue.js 3 with Rollup? Building a Vue.js 3 (beta) app with Rollup fails Jun 28, 2020
@akauppi akauppi added bug Something isn't working help wanted Extra attention is needed labels Jun 28, 2020
@akauppi
Copy link
Owner Author

akauppi commented Jun 29, 2020

Fixed by (see answer): https://stackoverflow.com/questions/62384191/rollup-vue-and-buble-unexpected-token-in-scss-file/62625441#62625441

Created vuejs/rollup-plugin-vue#364 to indicate upstream.

@akauppi akauppi closed this as completed Jul 3, 2020
@akauppi akauppi reopened this Jul 3, 2020
@akauppi akauppi added back-burner Something to keep an eye on, but not actively engage and removed bug Something isn't working help wanted Extra attention is needed labels Jul 3, 2020
@akauppi akauppi changed the title Building a Vue.js 3 (beta) app with Rollup fails Build of Vue.js 3 app needs scss Rollup plugin (should not) Sep 26, 2020
@akauppi
Copy link
Owner Author

akauppi commented Sep 26, 2020 •
edited
Loading

Keeping this only for tracking. Once the upstream issue is solved (with Rollup Vue plugin), remove scssHackNeeded code.

@akauppi akauppi added the packages/app Involves the package/app label Jan 27, 2021
@akauppi
Copy link
Owner Author

akauppi commented Jun 2, 2022

No longer relevant, since moved production builds to Vite. next.jun22

@akauppi akauppi closed this as completed Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
back-burner Something to keep an eye on, but not actively engage packages/app Involves the package/app
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akauppi