Skip to content

Commit ff95598

Browse files
committed
fix strings to be binary
1 parent 1da8702 commit ff95598

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

examples/example_parallel_requests_amp.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ function requestWithAmp(array $requests)
6262
try {
6363
yield $socket->write($request);
6464

65-
$data = '';
65+
$data = b'';
6666
while (null !== $chunk = yield $socket->read()) {
6767
// there are rare cases when MODBUS packet is received by multiple fragmented TCP packets and it could
6868
// take PHP multiple reads from stream to get full packet. So we concatenate data and check if all that

examples/example_parallel_requests_reactphp.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ function requestWithReactPhp(array $requests)
5151

5252
$connector->connect($request->getUri())->then(
5353
function (React\Socket\ConnectionInterface $connection) use ($request, $promise) {
54-
$receivedData = '';
54+
$receivedData = b'';
5555

5656
$connection->write($request);
5757

src/Network/StreamHandler.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ protected function receiveFrom(array $readStreams, float $timeout = null, $logge
6868
if ($logger) {
6969
$logger->debug("Stream {$streamId} @ index: {$streamIndex} received data: ", unpack('H*', $data));
7070
}
71-
$packetData = ($result[$streamIndex] ?? '') . $data;
71+
$packetData = ($result[$streamIndex] ?? b'') . $data;
7272
$result[$streamIndex] = $packetData;
7373

7474
// MODBUS SPECIFIC PART: if we received complete packet to at least one stream we were waiting

0 commit comments

Comments
 (0)