Skip to content

qibuild configure: no longer accepts -j #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmerejkowsky wants to merge 1 commit into
base: next
Choose a base branch
from
Open

qibuild configure: no longer accepts -j #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/qibuild/actions/configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@
"""

from qisys import ui

import qisys.parsers
import qibuild.cmake
import qibuild.parsers

def configure_parser(parser):
"""Configure parser for this action"""
qisys.parsers.build_parser(parser)
qibuild.parsers.cmake_configure_parser(parser)
qibuild.parsers.cmake_build_parser(parser)
qibuild.parsers.project_parser(parser)
if not parser.epilog:
parser.epilog = ""
Expand Down
4 changes: 4 additions & 0 deletions python/qibuild/test/test_qibuild_configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ def test_deps(qibuild_action):
# As should `qibuild configure --all`
qibuild_action("configure", "-a")

def test_error_when_using_dash_j(qibuild_action):
qibuild_action.add_test_project("world")
error = qibuild_action("configure", "world", "-j", "2", raises=True)
assert "unrecognized arguments" in error

def test_qi_use_lib(qibuild_action):
use_lib_proj = qibuild_action.add_test_project("uselib")
Expand Down