Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: add CI to block PRs #10

Open
alexcanessa opened this issue Mar 26, 2020 · 2 comments
Open

Suggestion: add CI to block PRs #10

alexcanessa opened this issue Mar 26, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@alexcanessa
Copy link
Owner

Is your feature request related to a problem? Please describe.
There is no CI running on merging PRs at the moment.

Describe the solution you'd like
When a PR gets created, CI checks the code and prevents if there are broken tests or the coverage (both test and type) are below the threshold.

Describe alternatives you've considered
CircleCI connected with the lint, test and (obviously) this package to check that the coverage stays the same.

@alexcanessa alexcanessa added the enhancement New feature or request label Mar 26, 2020
@tsaiDavid
Copy link
Contributor

Wondering if you have ideas or experience in testing packages like this one, in which the unit tests might involve an actual mock repo or structure? I feel like that could be helpful to ensure we mirror the actual usage of this tool.

@alexcanessa
Copy link
Owner Author

I did mock the lint function from type-coverage-core but at a very basic level + done some tests.
I'd like to have both unit and integration testing - I think that's all you need in a repo like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants