Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: .gitignored directories aren't ignored #69

Open
OmgImAlexis opened this issue Jul 24, 2021 · 3 comments
Open

Bug: .gitignored directories aren't ignored #69

OmgImAlexis opened this issue Jul 24, 2021 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@OmgImAlexis
Copy link

Describe the bug
My dist directory is showing up in the report.

To Reproduce

  1. Make a directory called dist.
  2. Add it to your .gitignore.
  3. Run typescript-coverage-report.

Expected behaviour
dist to be ignored as it's in the .gitignore.

Environment

  • Tool version: ^0.6.0
  • OS: macOS
  • Node version: v16.x
@OmgImAlexis OmgImAlexis added the help wanted Extra attention is needed label Jul 24, 2021
@alexcanessa
Copy link
Owner

@OmgImAlexis shouldn't you add dist to your ignore folders in the tsconfig instead?

@OmgImAlexis
Copy link
Author

@alexcanessa no as I have my includes setup. Is this not respecting the includes? 🤔

@alexcanessa
Copy link
Owner

@OmgImAlexis in theory it matches anything that TS matches too? I am not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcanessa @OmgImAlexis