This is caused by
|
if !sw.written { |
|
s.commitAndWriteSessionCookie(w, sr) |
|
} |
As demostrated in #216
|
func TestFlushPop(t *testing.T) { |
|
t.Parallel() |
|
|
|
sessionManager := New() |
|
|
|
mux := http.NewServeMux() |
|
mux.HandleFunc("/put", http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { |
|
sessionManager.Put(r.Context(), "foo", "bar") |
|
})) |
|
mux.HandleFunc("/get", http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { |
|
w.Write([]byte("")) |
|
s, _ := sessionManager.Pop(r.Context(), "foo").(string) |
|
w.Write([]byte(s)) |
|
})) |
|
|
|
ts := newTestServer(t, sessionManager.LoadAndSave(mux)) |
|
defer ts.Close() |
|
|
|
header, _ := ts.execute(t, "/put") |
|
token := extractTokenFromCookie(header.Get("Set-Cookie")) |
|
|
|
header, body := ts.execute(t, "/get") |
|
if body != "bar" { |
|
t.Errorf("want %q; got %q", "bar", body) |
|
} |
|
|
|
cookie := header.Get("Set-Cookie") |
|
if cookie == "" || extractTokenFromCookie(cookie) != token { |
|
t.Errorf("want %q; got %q", token, cookie) |
|
} |
|
|
|
header, body = ts.execute(t, "/get") |
|
if body != "" { |
|
t.Errorf("want %q; got %q", "", body) |
|
} |
|
|
|
cookie = header.Get("Set-Cookie") |
|
if cookie != "" { |
|
t.Errorf("want %q; got %q", "", cookie) |
|
} |
|
} |
If Pop happens after a w.Write, sw.written would be true. Therefore the commit would never happen
The second /get should have empty response, but it got bar instead:
go test github.com/alexedwards/scs/v2 -run '^TestFlushPop$' -timeout 30s -v -count 1
=== RUN TestFlushPop
=== PAUSE TestFlushPop
=== CONT TestFlushPop
session_test.go:379: want "yhKe4NJJYf3SgN2bcxyKgbBApVF312oIEg2Bo-qpC2U"; got ""
session_test.go:384: want ""; got "bar"
--- FAIL: TestFlushPop (0.00s)
FAIL
FAIL github.com/alexedwards/scs/v2 0.011s
FAIL
