Centos 7 errors during make for versions >1.9.4

[sbujam]

I get the following errors during make in a Centos 7 machine when trying to compile goacces v1.10 and later :

make  all-recursive
make[1]: Entering directory `/data/downloads/goaccess-1.10.1'
Making all in po
make[2]: Entering directory `/data/downloads/goaccess-1.10.1/po'
make[2]: Nothing to be done for `all'.
make[2]: Leaving directory `/data/downloads/goaccess-1.10.1/po'
make[2]: Entering directory `/data/downloads/goaccess-1.10.1'
depbase=`echo src/browsers.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
cc -std=gnu11 -DLOCALEDIR=\"/usr/local/share/locale\" -DHAVE_CONFIG_H -I. -I./src    -O2 -DSYSCONFDIR=\"/usr/local/etc\" -Wall -Wextra -Wnested-externs -Wformat=2 -g -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wwrite-strings -Wshadow -Wpointer-arith -Wsign-compare -Wbad-function-cast -Wcast-align -Wdeclaration-after-statement -Wshadow -Wold-style-definition  -pthread -MT src/browsers.o -MD -MP -MF $depbase.Tpo -c -o src/browsers.o src/browsers.c &&\
mv -f $depbase.Tpo $depbase.Po
In file included from src/error.h:48:0,
                 from src/browsers.c:39:
src/settings.h:216:3: error: expected specifier-qualifier-list before ‘_Atomic’
   _Atomic int stop_processing;      /* stop all processing */
   ^
src/browsers.c: In function ‘free_browsers_hash’:
src/browsers.c:370:23: error: ‘GConf’ has no member named ‘browsers_hash_idx’
   for (j = 0; j < conf.browsers_hash_idx; ++j) {
                       ^
src/browsers.c: In function ‘parse_browser_token’:
src/browsers.c:423:25: error: ‘GConf’ has no member named ‘browsers_hash_idx’
   if (is_dup (list, conf.browsers_hash_idx, line)) {
                         ^
src/browsers.c:428:26: error: ‘GConf’ has no member named ‘browsers_hash_idx’
   set_browser (list, conf.browsers_hash_idx, line, val);
                          ^
src/browsers.c:429:7: error: ‘GConf’ has no member named ‘browsers_hash_idx’
   conf.browsers_hash_idx++;
       ^
src/browsers.c: In function ‘parse_browsers_file’:
src/browsers.c:466:13: error: ‘GConf’ has no member named ‘browsers_hash_idx’
     if (conf.browsers_hash_idx >= MAX_CUSTOM_BROWSERS)
             ^
src/browsers.c: In function ‘verify_browser’:
src/browsers.c:630:23: error: ‘GConf’ has no member named ‘browsers_hash_idx’
   for (i = 0; i < conf.browsers_hash_idx; ++i) {
                       ^
make[2]: *** [src/browsers.o] Error 1
make[2]: Leaving directory `/data/downloads/goaccess-1.10.1'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/data/downloads/goaccess-1.10.1'
make: *** [all] Error 2

My build configuration:

  Prefix         : /usr/local
  Package        : goaccess
  Version        : 1.10.1
  Compiler flags :  -pthread
  Linker flags   : -lnsl -lncursesw -lmaxminddb -lz -lpthread
  UTF-8 support  : yes
  Dynamic buffer : no
  ASan           : no
  Geolocation    : GeoIP2
  Storage method : In-Memory with On-Disk Persistent Storage
  TLS/SSL        : no
  zlib support   : yes
  Bugs           : hello@goaccess.io

FYI, everything is working as expected up to v1.9.4 which is the one currently running on the machine.
gcc version 4.8.5 / glibc 2.17-326.el7_9.3

Is Centos7 still a 'supported' distribution? Can I overcome these errors somehow? (btw, I tried removing _Atomic, but got other errors at a later stage)

Thanks in advance!

[allinurl]

Thanks for sharing that. I'll try to get a copy of CentOS 7 and attempt to reproduce this on my end. I'll report back with what I find.

[allinurl]

Appreciate you sharing this. After looking into it, I believe the best approach here is to upgrade to a newer compiler. CentOS 7 reached end-of-life on June 30, 2024, so trying to restore some of the _Atomic features to support older GCC versions isn't the right path. I'd strongly recommend updating the compiler.

Closing it for now.