Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Improve SollCall return type encoding #536

Open
rouzwelt opened this issue Feb 21, 2024 · 0 comments
Open

[Feature] Improve SollCall return type encoding #536

rouzwelt opened this issue Feb 21, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@rouzwelt
Copy link

Component

sol-types, sol! macro

Describe the feature you would like

right now when we have somethingReturn and want to potentially abi encode it back, there is no direct way, one way is to use somethingCall::abi_encode_returns() but this wont accept the somethingReturn value directly and throws errors for impl bounds are not met.
a workaround is to deconstruct the somethingReturn value when calling the abi encode like:
somethingCall::abi_encode_returns(&(somethingReturn.field1, somethingReturn.field2, ...))

but this is not a really good API, so an improvement would be appreciated so we can just abi encode a return type as normally we encode any SollCall value.

Additional context

No response

@rouzwelt rouzwelt added the enhancement New feature or request label Feb 21, 2024
@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2024
@DaniPopes DaniPopes reopened this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants