[Bug] Signatures from sign_hash return Parity, but if converting to Vec and restoring, it returns NonEip155

[gusinacio]

Component

primitives

What version of Alloy are you on?

0.2.1

Operating System

None

Describe the bug

The following code doesn't work, it looks like it's returned Parity() every signature, but if we convert to bytes and restore elsewhere, it returns NonEip155.

The following test fails:

    #[test]
    fn test_parity() {
        let signer = PrivateKeySigner::random();
        // The message to sign.
        let message = b"hello";

        // Sign the message asynchronously with the signer.
        let signature = signer.sign_message_sync(message).unwrap();

        let value = signature.as_bytes().to_vec();
        let recovered_signature: Signature = value.as_slice().try_into().unwrap();
        assert_eq!(signature, recovered_signature);
    }

The error is the following:

assertion `left == right` failed
  left: Signature { inner: ecdsa::Signature<Secp256k1>(33828FC1FE49FB3177AA80459AE130BD8147158000FA701D7E33BC33B8EDDF25586239AF447392DD8AC6DACBE5E3F91B72AB5593BE3ED6DC702489CA4E2BE1B6), v: Parity(false), r: 23298637575944829774526378124809190621347391490807772432023406486951885135653, s: 39977079812416937747731152449858872909720600328418637835900651766296202699190 }
 right: Signature { inner: ecdsa::Signature<Secp256k1>(33828FC1FE49FB3177AA80459AE130BD8147158000FA701D7E33BC33B8EDDF25586239AF447392DD8AC6DACBE5E3F91B72AB5593BE3ED6DC702489CA4E2BE1B6), v: NonEip155(false), r: 23298637575944829774526378124809190621347391490807772432023406486951885135653, s: 39977079812416937747731152449858872909720600328418637835900651766296202699190 }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
test tap::context::rav::test::test_parity ... FAILED

failures:

failures:
    test::test_parity

[mattsse]

hmm these are indeed not symmetrical

core/crates/primitives/src/signature/parity.rs

Lines 19 to 24 in adcf7ad

	#[cfg(feature = "k256")]
	impl From<k256::ecdsa::RecoveryId> for Parity {
	fn from(value: k256::ecdsa::RecoveryId) -> Self {
	Self::Parity(value.is_y_odd())
	}
	}

core/crates/primitives/src/signature/parity.rs

Lines 45 to 56 in adcf7ad

	impl TryFrom<u64> for Parity {
	type Error = SignatureError;
	fn try_from(value: u64) -> Result<Self, Self::Error> {
	match value {
	0 | 1 => Ok(Self::Parity(value != 0)),
	27 | 28 => Ok(Self::NonEip155((value - 27) != 0)),
	value @ 35..=u64::MAX => Ok(Self::Eip155(value)),
	_ => Err(SignatureError::InvalidParity(value)),
	}
	}
	}

I assume this is the bug here:

core/crates/primitives/src/signature/parity.rs

Lines 87 to 94 in adcf7ad

	/// Return the y-parity byte as 27 or 28,
	/// in the case of a non-EIP155 signature.
	pub const fn y_parity_byte_non_eip155(&self) -> Option<u8> {
	match self {
	Self::NonEip155(v) | Self::Parity(v) => Some(*v as u8 + 27),
	_ => None,
	}
	}

invoked by

core/crates/primitives/src/signature/sig.rs

Line 334 in adcf7ad

sig[64] = self.v.y_parity_byte_non_eip155().unwrap_or(self.v.y_parity_byte());