Skip to content

Commit a4bf8e1

Browse files
committed
docs(ol): track the L1 height cache race in STR-4601
Reverting the L1 canonical chain purges the height cache before deleting the rows, so the submission tracker's canonical lookup can briefly see a reverted block during a reorg. It cannot produce a false rejection record short of a reorg as deep as the reorg-safe depth; the fix belongs in L1BlockManager.
1 parent 2f71dfb commit a4bf8e1

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

  • crates/ol/checkpoint/src/submission_tracker

‎crates/ol/checkpoint/src/submission_tracker/context.rs‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,9 @@ impl SubmissionTrackerContext for SubmissionTrackerContextImpl {
192192
}
193193

194194
fn get_canonical_l1_blockid_at(&self, height: L1Height) -> anyhow::Result<Option<L1BlockId>> {
195+
// TODO(STR-4601): reverting the L1 chain purges this cache before deleting the rows, so
196+
// during a reorg this can briefly return a reverted block. It can't produce a false
197+
// rejection record short of a reorg as deep as the reorg-safe depth.
195198
Ok(self.storage.l1().get_canonical_blockid_at_height(height)?)
196199
}
197200
}

0 commit comments

Comments
 (0)