O19: Add "add a from name" to the task list

Author: klssmith

app/main/views/service_settings/index.py

@@ -150,6 +150,7 @@ def service_email_sender_change(service_id):
             new_sender = current_service.name
 
         current_service.update(custom_email_sender_name=new_sender)
+        redis_client.set(f"{service_id}_has_confirmed_email_sender", b"true", ex=cache.DEFAULT_TTL)
 
         if from_sender_flow and not current_service.email_reply_to_addresses:
             return redirect(

app/models/service.py

@@ -294,6 +294,16 @@ def intending_to_send_sms(self):
             return self.has_sms_templates
         return self.volume_sms > 0
 
+    @property
+    def has_confirmed_email_sender(self):
+        if redis_client.get(f"{self.id}_has_confirmed_email_sender"):
+            return True
+        return False
+
+    @property
+    def needs_to_confirm_email_sender(self):
+        return self.intending_to_send_email and not self.has_confirmed_email_sender
+
     @cached_property
     def email_reply_to_addresses(self):
         return service_api_client.get_reply_to_email_addresses(self.id)
@@ -429,6 +439,7 @@ def go_live_checklist_completed(self):
                 self.go_live_sending_options_complete,
                 self.has_team_members_with_manage_service_permission,
                 self.has_templates,
+                not self.needs_to_confirm_email_sender,
                 not self.needs_to_add_email_reply_to_address,
                 not self.needs_to_change_sms_sender,
                 self.confirmed_unique,

app/templates/views/request-to-go-live.html

@@ -73,15 +73,23 @@
 
         {# all the conditional task #}
         {% if current_service.intending_to_send_email %}
-          {% do task_list_items.append(
+          {% do task_list_items.extend(
+            [{
+              "title": {
+                "text": "Choose a ‘from’ name",
+                "classes": "govuk-link--no-visited-state",
+              },
+              "href":  url_for('main.service_email_sender_change', service_id=current_service.id),
+              "status": completed_status if current_service.has_confirmed_email_sender else not_completed_status,
+            },
             {
               "title": {
                 "text": "Add a reply-to email address",
                 "classes": "govuk-link--no-visited-state",
               },
               "href":  url_for('main.service_email_reply_to', service_id=current_service.id),
               "status": completed_status if current_service.has_email_reply_to_address else not_completed_status,
-            }
+            }]
           )%}
         {% endif %}
         {% if (current_service.intending_to_send_sms and current_service.shouldnt_use_govuk_as_sms_sender) %}