Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer requirements are not complete #14

Open
rocketeerbkw opened this issue Mar 27, 2023 · 3 comments · May be fixed by #27
Open

Composer requirements are not complete #14

rocketeerbkw opened this issue Mar 27, 2023 · 3 comments · May be fixed by #27

Comments

@rocketeerbkw
Copy link
Member

Currently drupal/core-composer-scaffold is the only requirement listed, but this module requires drush at the least, and maybe others.

@bomoko bomoko linked a pull request Nov 13, 2023 that will close this issue
@kasperg
Copy link

kasperg commented Apr 10, 2024

Some other things that could be improved with the Composer requirements::

drupal/core-composer-scaffold is required without a version. However there are indirect dependencies of this package that are used here: guzzlehttp/guzzle, symfony/http-kernel, symfony/yaml and symfony/process.

It would be nice if the package either required these packages explicitly or a more limited version of Drupal e.g. drupal/core:^10.

We experienced upgrading a Drupal major version and amazeeio/drupal_integrations stopped working due to a change to symfony/process but the current requirements/conflicts did not trigger a problem.

@tobybellwood
Copy link
Member

thanks, @kasperg - we'll revisit that - it's hard with drush extensions living slightly outside the drupal ecosystem, but we're probably safe to release a new version that's more explicit in it's requirements now that 9 is long gone.

@kasperg
Copy link

kasperg commented Apr 10, 2024

👍 For the record: There is not necessarily a bug at the moment.

We experienced the problem using 0.3.7 from 2022 but were not prompted by upgrade to 0.4.0 by Composer later in our development process. Having seen the problem we will upgrade the package ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants