Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constituents listed as “Unknown” are not creators of artworks and they shouldn’t be mapped #42

Open
workergnome opened this issue Jul 25, 2017 · 7 comments
Labels

Comments

@workergnome
Copy link

Constituents who are creators of SAAM artworks have one of the following three codes: verified, candidate, or provisional in the WebConstituents table –only constituents with one of these three codes are selected for the web)

See #30 and #34

@rkbrasse
Copy link
Collaborator

rkbrasse commented Aug 7, 2017

Is this still blocking? Does the mapping need to be fixed?

@workergnome
Copy link
Author

I don't believe ISI has implemented this yet.

@bsnikhila
Copy link
Contributor

I believe this means the mapping should ignore the records with values blank and "Unidentified ..." in the Maker field of the WebMakers_view file. Please tell me if I am wrong.
If it is correct, do we have a list of such values to ignore?

@sosarasays
Copy link

Unidentified constituents should be mapped along with all of the other constituents who are creators of artworks.

Constituents who are creators of SAAM artworks have one of the following three codes: verified, candidate, or provisional in the WebConstituents table –only constituents with one of these three codes should be mapped.

Constituents without one of the three codes: verified, candidate, or provisional should not be mapped.

@bsnikhila
Copy link
Contributor

As mentioned in #30, there are some constituents that are in the WebConAltNames file that are not in any other file. Every constituent in the WebConstituents_person_view seems to have one of the three codes. So the additional constituents in the WebConAltNames file are the ones creating the issue. If these are not to be included in the mapping, only those constituents that are in the WebConstituents_person_view file should be included in WebConAltNames file. All the additional constituents have to be removed from the WebConAltNames file.

@kateblanch
Copy link

Hi @rkbrasse and @sosarasays - in the interest of timing...could I suggest you take a look at the discrepencies described above between WebConAltNames + WebConstituents_person_view? It might be easier to fix the source data at this point.

@rkbrasse
Copy link
Collaborator

rkbrasse commented Oct 4, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants