-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning that step.id is null when the Wizard is first time rendering. #29
Comments
Thanks! I think we probably shouldn't mark This shouldn't cause any issues with functionality but I'll try to open a PR soon to get rid of the warning. |
Great. Thanks ! |
Any update on this one @crosscompile ? |
@AntonKL To prevent the warning to pop I contionnaly set the "step" prop like this: <Steps key={step.id} step={step.id ? step : undefined}> This way while the step id is null the "step" props is not pass |
Seems like a simple fix. @crosscompile why not accept a PR to fix the issue? |
This issue is stale because it has been open 30 days with no activity. Remove no-issue-activity label or comment or this will be closed in 5 days. |
This issue is stale because it has been open 30 days with no activity. |
This issue is stale because it has been open 30 days with no activity. |
This issue is stale because it has been open 30 days with no activity. |
Hi,
First of all great library. Does what it says and does it best.
I was trying it out and was getting warning.
Warning: Failed prop type: The prop
step.idis marked as required in
Steps, but its value is
null. in Steps (created by Wizard) in Wizard (created by Onboarding)
Turns out the same warning was replicated in the console.log of the official examples from add animation onwards.
Problem:
Basically whenever I try to render Step, using Wizard's render api, this warning shows up.
The default props of Steps.id = null. When the object is rendering it throws an error.
Can you please check?
The text was updated successfully, but these errors were encountered: